pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Amit Langote <amitlangote09@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: unsupportable composite type partition keys
Date: Mon, 23 Dec 2019 13:57:47 -0500
Message-ID: <20151.1577127467@sss.pgh.pa.us> (raw)
In-Reply-To: <CA+HiwqFBwbmkqvKM-CmoK6yOcokwWcOzjz-fP1O317qn8kgGEA@mail.gmail.com>
References: <CA+HiwqFUzjfj9HEsJtYWcr1SgQ_=iCAvQ=O2Sx6aQxoDu4OiHw@mail.gmail.com>
	<5361.1576602769@sss.pgh.pa.us>
	<CA+HiwqGiGBgFFcL6YGKRqfX1-gYKmuLLG_JwU_UaSaX2J+jehQ@mail.gmail.com>
	<28160.1576676326@sss.pgh.pa.us>
	<CA+HiwqENLY2ta0goA0jcfk4cWdj2W0r6Ywjf=PQiMpJkyXygmg@mail.gmail.com>
	<26766.1576947735@sss.pgh.pa.us>
	<24653.1576962784@sss.pgh.pa.us>
	<CA+HiwqGug69_zhRCzENJPg_Ynpx_Eb-2-=N1u2Zw3X6T1S3wbQ@mail.gmail.com>
	<25383.1577112556@sss.pgh.pa.us>
	<CA+HiwqFBwbmkqvKM-CmoK6yOcokwWcOzjz-fP1O317qn8kgGEA@mail.gmail.com>

Amit Langote <amitlangote09@gmail.com> writes:
> On Mon, Dec 23, 2019 at 23:49 Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Oh, interesting --- I hadn't been paying much attention to that thread.
>> I'll compare your PoC there to what I did.

> Actually, I should’ve said that your patch is much better attempt at
> getting this in order, so there’s not much to see in my patch really. :)

One thing I see is that you chose to relocate RelationGetPartitionDesc's
declaration to partdesc.h, whereupon RelationBuildPartitionDesc doesn't
have to be exported at all anymore.  Perhaps that's a better factorization
than what I did.  It supposes that any caller of RelationGetPartitionDesc
is going to need partdesc.h, but that seems reasonable.  We could likewise
move RelationGetPartitionKey to partcache.h.

			regards, tom lane





view thread (31+ messages)  latest in thread

Message-ID: <20151.1577127467@sss.pgh.pa.us>
Permalink:  ../20151.1577127467@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/20151.1577127467@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, amitlangote09@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: unsupportable composite type partition keys
  In-Reply-To: <20151.1577127467@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox