From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: jeff.janes@gmail.com
Cc: thomas.munro@enterprisedb.com
Cc: tgl@sss.pgh.pa.us
Cc: pgsql-hackers@postgresql.org
Subject: Re: Making tab-complete.c easier to maintain
Date: Mon, 16 Nov 2015 12:16:07 -0300
Message-ID: <20151116151606.GW614468@alvherre.pgsql> (raw)
In-Reply-To: <20151112.131627.11088278.horiguchi.kyotaro@lab.ntt.co.jp>
References: <CAEepm=1ns0rbo+xun_j6_PwDT6zmEPuNggy=Vaie-3peF2C44Q@mail.gmail.com>
<CAMkU=1zRsaaSF_8qyQNYqOcDt0Xa7Awk==YdWCeTZtNhjnPNww@mail.gmail.com>
<20151023175058.GA3391@alvherre.pgsql>
<20151112.131627.11088278.horiguchi.kyotaro@lab.ntt.co.jp>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Kyotaro HORIGUCHI wrote:
> Auto-generating from grammer should be the ultimate solution but
> I don't think it will be available. But still I found that the
> word-splitting-then-match-word-by-word-for-each-matching is
> terriblly unmaintainable and poorly capable. So, how about
> regular expressions?
I don't think this is an improvement. It seems to me that a lot more
work is required to maintain these regular expressions, which while
straightforward are not entirely trivial (harder to read).
If we could come up with a reasonable format that is pre-processed to a
regexp, that might be better. I think Thomas' proposed patch is closer
to that than Horiguchi-san's.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, horiguchi.kyotaro@lab.ntt.co.jp, jeff.janes@gmail.com, thomas.munro@enterprisedb.com, tgl@sss.pgh.pa.us
Subject: Re: Making tab-complete.c easier to maintain
In-Reply-To: <20151116151606.GW614468@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox