From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>
Subject: Re: pgbench stats per script & other stuff
Date: Tue, 29 Mar 2016 14:55:16 -0300
Message-ID: <20160329175516.GA881582@alvherre.pgsql> (raw)
In-Reply-To: <alpine.DEB.2.10.1603280920070.16239@sto>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Fabien COELHO wrote:
>
> >- that it does work:-) I'm not sure what happens by the script selection
> > process, it should be checked carefully because it was not designed
> > with allowing a zero weight, and it may depend on its/their positions.
> > It may already work, but it really needs checking.
>
> Hmmm, it seems ok.
It's not -- if you used -i, it died saying weight is zero.
> >- I would suggest that a warning is shown when a weight is zero,
> > something like "warning, script #%d weight is zero, will be ignored".
>
> includes such a warning.
I didn't include this part.
Pushed.
In doing this, I noticed that the latency output is wrong if you use -T
instead of -t; it always says the latency is zero because "duration" is
zero. I suppose it should be like in the attached instead. At the same
time, it says "latency average: XYZ" instead of "latency average = XYZ"
as in printSimpleStats, which doesn't look terribly important. But the
line appears in the SGML docs.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, coelho@cri.ensmp.fr, jeff.janes@gmail.com
Subject: Re: pgbench stats per script & other stuff
In-Reply-To: <20160329175516.GA881582@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox