From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Robbie Harwood <rharwood@redhat.com>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: [PATCH v12] GSSAPI encryption support
Date: Tue, 5 Apr 2016 17:58:17 -0300
Message-ID: <20160405205817.GA366676@alvherre.pgsql> (raw)
In-Reply-To: <jlgfuuzstks.fsf@thriss.redhat.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Robbie Harwood wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > It seems to me that the right solution for this is to create a new
> > memory context which is a direct child of TopMemoryContext, so that
> > palloc can be used, and so that it can be reset separately, and that it
> > doesn't suffer from resets of other contexts. (I think Michael's point
> > is that if those chunks were it a context of their own, you wouldn't
> > need the pfrees but a MemCxtReset would be enough.)
>
> Hmm, that's also an option. I read Michael's point as arguing for
> calloc()/free() rather than a new context, but I could be wrong.
Yeah, if you weren't using stringinfos that would be an option, but
since you are I think that's out of the question.
> A question, though: it it valuable for the context to be reset()able
> separately? If there were more than just these two buffers going into
> it, I could see it being convenient - especially if it were for
> different encryption types, for instance - but it seems like it would be
> overkill?
If two buffers is all, I think retail pfrees are fine. I haven't
actually read the patch.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, rharwood@redhat.com, michael.paquier@gmail.com
Subject: Re: [PATCH v12] GSSAPI encryption support
In-Reply-To: <20160405205817.GA366676@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox