From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Ants Aasma <ants.aasma@eesti.ee>
Cc: Joshua D. Drake <jd@commandprompt.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Reviewing freeze map code
Date: Tue, 17 May 2016 15:32:08 -0400
Message-ID: <20160517193208.GA169606@alvherre.pgsql> (raw)
In-Reply-To: <CAD21AoBuNs7kBp=EAhFHEmffy6SaCZ0Bfsux3hAdp9n90abmVA@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Masahiko Sawada wrote:
> On Mon, May 16, 2016 at 10:49 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> > We should support scan_all only with the new-style options syntax for
> > VACUUM; that is, vacuum (scan_all) rename. That doesn't require
> > making scan_all a keyword, which is good: this is a minor feature, and
> > we don't want to bloat the parsing tables for it.
>
> I agree with having new-style options syntax.
> Isn't it better to have SCAN_ALL option without parentheses?
>
> Syntaxes are;
> VACUUM SCAN_ALL table_name;
> VACUUM SCAN_ALL; -- for all tables on database
No, I agree with Robert that we shouldn't add any more such options to
avoid keyword proliferation.
Syntaxes are;
VACUUM (SCAN_ALL) table_name;
VACUUM (SCAN_ALL); -- for all tables on database
Is SCAN_ALL really the best we can do here? The business of having an
underscore in an option name has no precedent (other than
CURRENT_DATABASE and the like). How about COMPLETE, TOTAL, or WHOLE?
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, sawada.mshk@gmail.com, robertmhaas@gmail.com, ants.aasma@eesti.ee, jd@commandprompt.com, sfrost@snowman.net, andres@anarazel.de
Subject: Re: Reviewing freeze map code
In-Reply-To: <20160517193208.GA169606@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox