From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Nikolay Shaplov <n.shaplov@postgrespro.ru>
Cc: pgsql-hackers@postgresql.org, Fabrízio de Royes Mello <fabriziomello@gmail.com>
Subject: Re: [PROPOSAL] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind
Date: Wed, 25 May 2016 14:03:17 -0400
Message-ID: <20160525180317.GA598084@alvherre.pgsql> (raw)
In-Reply-To: <2675173.UdFh6OGSxV@nataraj-amd64>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Nikolay Shaplov wrote:
> В письме от 25 мая 2016 13:25:38 Вы написали:
> > Teodor Sigaev wrote:
> > > >This all should me moved behind "access method" abstraction...
> > >
> > > +1 relopt_kind should be moved in am, at least. Or removed.
> >
> > Hm, but we have tablespace options too, so I'm not sure that using AM as
> > abstraction level is correct.
> We will use am for all indexes, and keep all the rest in relopotion.c for
> non-indexes. May be divided options catalog into sections one section for each
> kind.
That makes sense. I can review the patch later.
> And as I also would like to use this code for dynamic attoptions later, I
> would like to remove relopt_kind at all. Because it spoils live in that case.
As I remember, Fabrízio (in CC) had a patch for dynamic reloptions, but
there was some problem with it and we dumped it; see
https://www.postgresql.org/message-id/CAFcNs+rqCq1H5eXW-cvdti6T-xo2STEkhjREx=OdmAkK5tiOOw@mail.gmail...
for previous discussion.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, n.shaplov@postgrespro.ru, fabriziomello@gmail.com
Subject: Re: [PROPOSAL] Move all am-related reloption code into src/backend/access/[am-name] and get rid of relopt_kind
In-Reply-To: <20160525180317.GA598084@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox