From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: CharSyam <charsyam@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Typo Patch
Date: Tue, 5 Jul 2016 15:22:33 -0400
Message-ID: <20160705192233.GA504891@alvherre.pgsql> (raw)
In-Reply-To: <CAMrLSE7ng-f4T9kP9gGO77WSEcvos6cQNAKpHecEKzc=bs1RGQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
CharSyam wrote:
> Yes, Some typos problems, It is hard to figure them out.
> But in this patch, guranteed is just misspelling of guaranteed.
I agree with Robert: the sentence as a whole makes no sense:
* We need to check all possible distances, so reset Lpos
* to guaranteed not yet satisfied position.
It's hard to justify changing a single character when what we should be
doing is rewriting the comment completely.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, charsyam@gmail.com, robertmhaas@gmail.com
Subject: Re: Typo Patch
In-Reply-To: <20160705192233.GA504891@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox