From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: Increasing timeout of poll_query_until for TAP tests
Date: Wed, 3 Aug 2016 13:34:05 -0400
Message-ID: <20160803173405.GA636698@alvherre.pgsql> (raw)
In-Reply-To: <CAB7nPqQtwOL-2hv_8FSvadz3CyS3AmUWgZ-EBjcfdrjNidcarA@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Michael Paquier wrote:
> On Wed, Aug 3, 2016 at 7:21 AM, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> > Why not capture both items in a single select, such as in the attached
> > patch?
>
> Let me test this....
> [... A while after ...]
> This looks to work properly. 12 runs in a row have passed.
Okay, applied that way.
BTW, one-line long queries look awful in that perl code. I don't
propose to change anything now, but I propose that long queries are
split using here-docs in new code,
$node->safe_psql(<<EQ);
SELECT foo
FROM bar
EQ
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, michael.paquier@gmail.com
Subject: Re: Increasing timeout of poll_query_until for TAP tests
In-Reply-To: <20160803173405.GA636698@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox