From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Jesper Pedersen <jesper.pedersen@redhat.com>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pageinspect: Hash index support
Date: Tue, 27 Sep 2016 01:00:05 -0300
Message-ID: <20160927040005.GA294546@alvherre.pgsql> (raw)
In-Reply-To: <c982b01c-06bc-485b-5dde-057ee244261a@2ndquadrant.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Peter Eisentraut wrote:
> On 9/26/16 1:39 PM, Jesper Pedersen wrote:
> >> - hash_metap result fields spares and mapp should be arrays of integer.
> >
> > B-tree and BRIN uses a 'text' field as output, so left as is.
>
> These fields are specific to hash, so the precedent doesn't necessarily
> apply.
>
> >> - The data field could be of type bytea.
> >
> > Left as is, for same reasons as 'spares' and 'mapp'.
>
> Comments from others here? Why not use bytea instead of text?
The BRIN pageinspect functions aren't a particularly well thought-out
precedent IMO. There was practically no review of that part of the BRIN
patch, and I just threw it together in the way that seemed to make the
most sense at the time. If there's some reason why some other way is
better for hash indexes, that should be followed rather than mimicking
BRIN.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, peter.eisentraut@2ndquadrant.com, jesper.pedersen@redhat.com, michael.paquier@gmail.com, ashu.coek88@gmail.com, jeff.janes@gmail.com
Subject: Re: pageinspect: Hash index support
In-Reply-To: <20160927040005.GA294546@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox