From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: DROP FUNCTION of multiple functions
Date: Tue, 1 Nov 2016 12:15:03 -0300
Message-ID: <20161101151503.GA29685@eldon.alvh.no-ip.org> (raw)
In-Reply-To: <6dcd1248-4631-a4c1-65d7-b873fbcada6c@2ndquadrant.com>
References: <6dcd1248-4631-a4c1-65d7-b873fbcada6c@2ndquadrant.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Peter Eisentraut wrote:
> Here is a patch series that implements several changes in the internal
> grammar and node representation of function signatures. They are not
> necessarily meant to be applied separately, but they explain the
> progression of the changes nicely, so I left them like that for review.
I think patches 1-4 and 6 are pretty clearly straight cleanup and it
seems fine to me to push them ahead of the rest. I didn't review super
carefully but it looks good on a quick glance. I'd just advise to pay
special attention to the objectaddress.sql test and the UI involved
there (which you appear to have done already).
Patch 5 is obviously a new feature and I would put that one in a
separate commit from the first four plus six. (I'm not clear why you
put 6 after 5 instead of before.)
I'm not at all sure about patch 7. Maybe that one is okay, not sure,
but since it's bigger I didn't look at it.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, peter.eisentraut@2ndquadrant.com
Subject: Re: DROP FUNCTION of multiple functions
In-Reply-To: <20161101151503.GA29685@eldon.alvh.no-ip.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox