From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org
Subject: Re: pg_dump vs. TRANSFORMs
Date: Thu, 8 Dec 2016 10:11:57 -0500
Message-ID: <20161208151156.GD23417@tamriel.snowman.net> (raw)
In-Reply-To: <4955.1481209396@sss.pgh.pa.us>
References: <20160504183952.GE10850@tamriel.snowman.net>
<20161207200915.GZ23417@tamriel.snowman.net>
<729.1481151371@sss.pgh.pa.us>
<20161208142116.GC23417@tamriel.snowman.net>
<4955.1481209396@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Tom,
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Stephen Frost <sfrost@snowman.net> writes:
> > * Tom Lane (tgl@sss.pgh.pa.us) wrote:
> >> I have a vague feeling that the code for dumping casts and/or transforms
> >> may have some assumptions that the underlying function is also being
> >> dumped. Although maybe the assumption was really only what's fixed here,
> >> ie that there be a DumpableObject for the function. Anyway, take a close
> >> look for that.
>
> > I'll look around and see, though my hunch is that, at some point, we
> > were just pulling all functions and then an optimization was added to
> > exclude pg_catalog and no one noticed that it broke casts using built-in
> > functions.
>
> Nah, that's historical revisionism --- the exclusion for system functions
> is very ancient. It certainly predates transforms altogether, and
> probably predates the cast-dumping code in anything like its current form.
Oh, certainly it predates transforms entirely, but I completely expect
that code to have been copied from dumpCast().
> I think the expectation was that casts using built-in functions were
> also built-in and so needn't be dumped. There may be a comment about it
> somewhere, which would need to be revised now.
I'll look and see.
> (Actually, the most likely way in which this would break things is if
> it started causing built-in casts to get dumped ... have you checked?)
I did and it doesn't cause built-in casts to be dumped because we have
the FirstNormalObjectId check in selectDumpableCast(). We don't have
that for transforms (it just uses the generic selectDumpableObject
routine), but we also don't have any built-in transforms.
Thanks!
Stephen
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, tgl@sss.pgh.pa.us
Subject: Re: pg_dump vs. TRANSFORMs
In-Reply-To: <20161208151156.GD23417@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox