From: Stephen Frost <sfrost@snowman.net>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_dump emits ALTER TABLE ONLY partitioned_table
Date: Fri, 17 Feb 2017 08:32:51 -0500
Message-ID: <20170217133251.GK9812@tamriel.snowman.net> (raw)
In-Reply-To: <7682253a-6f79-6a92-00aa-267c4c412870@lab.ntt.co.jp>
References: <7682253a-6f79-6a92-00aa-267c4c412870@lab.ntt.co.jp>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Amit,
* Amit Langote (Langote_Amit_f8@lab.ntt.co.jp) wrote:
> In certain cases, pg_dump's dumpTableSchema() emits a separate ALTER TABLE
> command for those schema elements of a table that could not be included
> directly in the CREATE TABLE command for the table.
Any chance we could start adding regression tests for how pg_dump
handles partitions? I'm just about to the point where I have pretty
much everything else covered (at least in pg_dump.c, where it's not a
hard-to-reproduce error/exit case, or something version-dependent).
If you have any questions about how the TAP tests for pg_dump work, or
about how to generate code-coverage checks to make sure you're at least
hitting every line (tho, of course, not every possible path), let me
know. I'd be happy to explain them.
Thanks!
Stephen
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, Langote_Amit_f8@lab.ntt.co.jp
Subject: Re: pg_dump emits ALTER TABLE ONLY partitioned_table
In-Reply-To: <20170217133251.GK9812@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox