From: Stephen Frost <sfrost@snowman.net>
To: David Fetter <david@fetter.org>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: michael.paquier@gmail.com
Cc: tgl@sss.pgh.pa.us
Cc: robertmhaas@gmail.com
Cc: pavel.stehule@gmail.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: IF (NOT) EXISTS in psql-completion
Date: Tue, 28 Feb 2017 10:39:01 -0500
Message-ID: <20170228153901.GH9812@tamriel.snowman.net> (raw)
In-Reply-To: <20170228070746.GA24888@fetter.org>
References: <CAB7nPqQ-FaDP6GdfAeNOdYMGNgohD7rEf6R92QyUyC0y+cOQ3A@mail.gmail.com>
<1603.1488158409@sss.pgh.pa.us>
<CAB7nPqQr7apg8W+p41W1azTjy7LSasSEvWvKePTU4knnxWCZkw@mail.gmail.com>
<20170227.133305.68651190.horiguchi.kyotaro@lab.ntt.co.jp>
<20170228045317.GE9812@tamriel.snowman.net>
<20170228070746.GA24888@fetter.org>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
* David Fetter (david@fetter.org) wrote:
> On Mon, Feb 27, 2017 at 11:53:17PM -0500, Stephen Frost wrote:
> > * Kyotaro HORIGUCHI (horiguchi.kyotaro@lab.ntt.co.jp) wrote:
> > > I suppose it is for suggesting what kind of word should come
> > > there, or avoiding silence for a tab. Or for symmetry with other
> > > types of manipulation, like DROP. Another possibility is creating
> > > multiple objects with similar names, say CREATE TABLE employee_x1,
> > > CREATE TABLE employee_x2. Just trying to complete existing
> > > *schema* is one more another possible objective.
> >
> > I don't buy any of these arguments either. I *really* don't want us
> > going down some road where we try to make sure that hitting 'tab'
> > never fails...
>
> Wouldn't that just be a correct, grammar-aware implementation of tab
> completion? Why wouldn't you want that?
No, it wouldn't, it would mean we have to provide something for cases
where it doesn't make sense to try and provide an answer, as being
discussed here for CREATE TABLE.
We can't provide an answer based on tab-completion to what you want to
call your new table.
Thanks!
Stephen
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, david@fetter.org, horiguchi.kyotaro@lab.ntt.co.jp, michael.paquier@gmail.com, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, pavel.stehule@gmail.com
Subject: Re: IF (NOT) EXISTS in psql-completion
In-Reply-To: <20170228153901.GH9812@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox