From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Tels <nospam-pg-abuse@bloodgate.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Joe Conway <mail@joeconway.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Upgrading postmaster's log messages about bind/listen errors
Date: Fri, 10 Mar 2017 11:27:22 -0500
Message-ID: <20170310162722.GG9812@tamriel.snowman.net> (raw)
In-Reply-To: <12776.1489160501@sss.pgh.pa.us>
References: <9564.1489091245@sss.pgh.pa.us>
<e3a1715d-dd25-d9bb-4a28-6839c242a2f7@joeconway.com>
<CA+TgmoYpQiZMPHfQX8x8P+RqEq0XQBSb32QHTZ8dDwU+aP3qzg@mail.gmail.com>
<19479.1489121003@sss.pgh.pa.us>
<8371d0860a6019e5630bcdd2a96610ab.squirrel@sm.webmail.pair.com>
<20170310135656.GD9812@tamriel.snowman.net>
<12776.1489160501@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Stephen Frost <sfrost@snowman.net> writes:
> > database system is ready to accept connections on (1.2.3.4)
>
> That would be a problem from a couple of directions. First, it wouldn't
> be unusual for there to be half a dozen addresses to list, not just one.
> Even a default configuration would probably read like
>
> database system is ready to accept connections on (127.0.0.1, ::1, /tmp/.s.PGSQL.5432)
Yeah, that's probably a bit much to have all on one line.
> which doesn't seem very appetizing to me. Second, it would be
> considerably messier to implement because the "ready to accept
> connections" message comes out physically distant from the
> StreamServerPort function, and we don't save the struct addrinfo list
> past the end of that function. So I think the logging setup I had in
> my patch is pretty much the only sane way to do it, and we just have
> to decide whether it's worth exposing at default log level or not.
I definitely think we should include it at the default log level. We
certainly wouldn't be the first daemon process to do so (bind9 comes to
mind, but I notice ntpd, nrpe, and strongswan do also, and probably some
others).
Thanks!
Stephen
Attachments:
[application/pgp-signature] signature.asc (818B, ../20170310162722.GG9812@tamriel.snowman.net/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, tgl@sss.pgh.pa.us, nospam-pg-abuse@bloodgate.com, robertmhaas@gmail.com, mail@joeconway.com
Subject: Re: Upgrading postmaster's log messages about bind/listen errors
In-Reply-To: <20170310162722.GG9812@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox