pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: WIP: Faster Expression Processing v4
Date: Tue, 14 Mar 2017 20:20:57 -0700
Message-ID: <20170315032057.wtwsqblmxmlsvvj6@alap3.anarazel.de> (raw)
In-Reply-To: <cd805280-38f9-ffa3-a8ac-2cc9eda86ebd@2ndquadrant.com>
References: <20170307030137.lpo4japv5oqgbqpz@alap3.anarazel.de>
	<2090fd00-4dec-7b42-f700-64308958504c@2ndquadrant.com>
	<20170313080351.4g5oubxcj4xj5y7t@alap3.anarazel.de>
	<fcdaa51b-e905-72e0-39dd-5e22f535a253@2ndquadrant.com>
	<20170314065259.ffef4tfhgbsaieoe@alap3.anarazel.de>
	<69b7bb0e-8dab-3d39-1a89-3c6ab6409f64@iki.fi>
	<20170314224706.nxvtapenky6eom3z@alap3.anarazel.de>
	<21290.1489534452@sss.pgh.pa.us>
	<20170314234016.5jgz4tjim2xf6j3c@alap3.anarazel.de>
	<cd805280-38f9-ffa3-a8ac-2cc9eda86ebd@2ndquadrant.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 2017-03-14 23:10:25 -0400, Peter Eisentraut wrote:
> On 3/14/17 19:40, Andres Freund wrote:
> > Any idea why we introduce __ stuff?
> 
> Because the symbols start with an underscore:
> 
> /* Define to 1 if your compiler understands _Static_assert. */
> #undef HAVE__STATIC_ASSERT

Oh, I guess that makes some sense.  But we do so very inconsistently,
given we only keep the leading underscores not the trailing ones (see
HAVE__VA_ARGS, HAVE_FUNCNAME__FUNC).


> But we don't need to introduce underscores that are not there.

Indeed.  Don't want to repost for just this, but consider it adapted
(and moved as requested by Tom).

- Andres


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (107+ messages)  latest in thread

Message-ID: <20170315032057.wtwsqblmxmlsvvj6@alap3.anarazel.de>
Permalink:  ../20170315032057.wtwsqblmxmlsvvj6@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20170315032057.wtwsqblmxmlsvvj6@alap3.anarazel.de

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: andres@anarazel.de, peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, hlinnaka@iki.fi, tomas.vondra@2ndquadrant.com
  Subject: Re: WIP: Faster Expression Processing v4
  In-Reply-To: <20170315032057.wtwsqblmxmlsvvj6@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox