From: Stephen Frost <sfrost@snowman.net>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: David Steele <david@pgmasters.net>
Cc: Tsunakawa, Takayuki <tsunakawa.takay@jp.fujitsu.com>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: PATCH: Make pg_stop_backup() archive wait optional
Date: Wed, 22 Mar 2017 15:14:51 -0400
Message-ID: <20170322191451.GY9812@tamriel.snowman.net> (raw)
In-Reply-To: <CAHGQGwFd+7D5UPwLLCW3=5mmDzXOKN56gySRUqdRzaeVK_L2HQ@mail.gmail.com>
References: <CA+TgmoZfjF2k6N8Rfga20bXxnRAttuz8N6dvxeOu=t3j0FYYsg@mail.gmail.com>
<081cbf08-35c1-4580-8c31-3ae70b507fb1@pgmasters.net>
<0A3221C70F24FB45833433255569204D1F6B3F95@G01JPEXMBYT05>
<0A3221C70F24FB45833433255569204D1F6B5134@G01JPEXMBYT05>
<49d70e8e-33bf-2390-e717-ba9562621aa4@pgmasters.net>
<0A3221C70F24FB45833433255569204D1F6B607B@G01JPEXMBYT05>
<CAHGQGwHRmE+db96=9FDPLVxWRN0gSf6kU7nM6-WnEKot2OanOg@mail.gmail.com>
<ee92e800-f983-c3a7-ddae-92acae162832@pgmasters.net>
<20170322153703.GK9812@tamriel.snowman.net>
<CAHGQGwFd+7D5UPwLLCW3=5mmDzXOKN56gySRUqdRzaeVK_L2HQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Fujii,
* Fujii Masao (masao.fujii@gmail.com) wrote:
> On Thu, Mar 23, 2017 at 12:37 AM, Stephen Frost <sfrost@snowman.net> wrote:
> > * David Steele (david@pgmasters.net) wrote:
> >> On 3/21/17 2:34 PM, Fujii Masao wrote:
> >> >The patch basically looks good to me, but one comment is;
> >> >backup.sgml (at least the description for "Making a non-exclusive
> >> >low level backup) seems to need to be updated.
> >>
> >> Agreed. Added in the attached patch and rebased on 8027556.
>
> Thanks for updating the patch!
>
> -SELECT * FROM pg_stop_backup(false);
> +SELECT * FROM pg_stop_backup(false [, true ]);
>
> I think that it's better to get rid of "[" and "]" from the above because
> IMO this should be the command example that users actually can run.
Using the '[' and ']' are how all of the optional arguments are
specified in the documentation, see things like current_setting() in our
existing documentation:
https://www.postgresql.org/docs/9.6/static/functions-admin.html> + If the backup process monitors the WAL archiving process independently,
> + the second parameter (which defaults to true) can be set to false to
> + prevent <function>pg_stop_backup</> from blocking until all WAL is
> + archived. Instead, the function will return as soon as the stop backup
> + record is written to the WAL. This option must be used with caution:
> + if WAL archiving is not monitored correctly then the result might be a
> + useless backup.
>
> You added this descriptions into the step #4 in the non-exclusive
> backup procedure.. But since the step #5 already explains how
> pg_stop_backup has to do with WAL archiving, I think that it's better
> to update (or add something like the above descriptions into)
> the step #5. Thought?
That seems pretty reasonable to me.
> + If the backup process monitors the WAL archiving process independently,
>
> Can we explain "monitor the WAL archiving process" part a bit more
> explicitly? For example, "monitor and ensure that all WAL segment files
> required for the backup are successfully archived".
Sure, makes sense. I'll add some language along those lines.
> > I've started looking at this. Seems pretty straight-forward and will
> > try to get it committed later today.
>
> Thanks!
My apologies if you had intended to look at committing this, I just
noticed that it hadn't been 'claimed' yet in the CF app and did so to
move forward with it. I didn't mean to step on anyone's 'toes'.
Thanks!
Stephen
Attachments:
[application/pgp-signature] signature.asc (818B, ../20170322191451.GY9812@tamriel.snowman.net/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, masao.fujii@gmail.com, david@pgmasters.net, tsunakawa.takay@jp.fujitsu.com, michael.paquier@gmail.com
Subject: Re: PATCH: Make pg_stop_backup() archive wait optional
In-Reply-To: <20170322191451.GY9812@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox