From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Noah Misch <noah@leadboat.com>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_dump emits ALTER TABLE ONLY partitioned_table
Date: Mon, 10 Apr 2017 10:12:51 -0400
Message-ID: <20170410141251.GJ9812@tamriel.snowman.net> (raw)
In-Reply-To: <7227.1491790247@sss.pgh.pa.us>
References: <7682253a-6f79-6a92-00aa-267c4c412870@lab.ntt.co.jp>
<CA+TgmoYAWqUukz-Q6GOnv=D82bokRbsohYrRj_gJYkwBBz79-Q@mail.gmail.com>
<9599c3b3-87d4-39d1-1f75-d205a726b863@lab.ntt.co.jp>
<CA+TgmoYpVps0dH_Nj7At5yonKJZ-Qzezq4Z_3ZnYLPwZgGgBZg@mail.gmail.com>
<9c6a9a7d-684f-bb8b-b972-ee20445a9e6d@lab.ntt.co.jp>
<20170409235057.GA2842536@tornado.leadboat.com>
<CA+Tgmoba3SDoSyPJ5b4-n1S8fd+_vhKmKBpfwUenH_+=PUgQDg@mail.gmail.com>
<7227.1491790247@sss.pgh.pa.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Tom, Robert,
* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Robert Haas <robertmhaas@gmail.com> writes:
> > I would appreciate help from other contributors and committers on this
> > open item; pg_dump is not my strong point. In the absence of such
> > help, I will do my best with it. I will set aside time this week to
> > study this and send another update no later than Thursday.
>
> The proposed patch seems rather ad-hoc, and I think that it is working
> around a backend behavior that might be broken.
Yeah, I'm not a big fan of the proposed patch either.
> While I admit that I've not been paying close attention to the whole
> table partitioning business, I wonder whether we have any clearly written
> down specification about (a) how much partition member tables are allowed
> to deviate schema-wise from their parent, and (b) how DDL semantics on
> partitioned tables differ from DDL semantics for traditional inheritance.
> Obviously those are closely related questions. But the fact that this
> bug exists at all shows that there's been some lack of clarity on (b),
> and so I wonder whether we have any clarity on (a) either.
Right. I thought I had understood that partition child tables really
can't deviate from the parent table in terms of columns or constraints
but might be allowed to differ with regard to indexes (?).
I'll try looking into this also, I should be able to spend some time on
it this week.
Thanks!
Stephen
Attachments:
[application/pgp-signature] signature.asc (818B, ../20170410141251.GJ9812@tamriel.snowman.net/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, noah@leadboat.com, Langote_Amit_f8@lab.ntt.co.jp
Subject: Re: pg_dump emits ALTER TABLE ONLY partitioned_table
In-Reply-To: <20170410141251.GJ9812@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox