public inbox for [email protected]  
help / color / mirror / Atom feed
From: Stephen Frost <[email protected]>
To: Michael Paquier <[email protected]>
Cc: Craig Ringer <[email protected]>
Cc: Noah Misch <[email protected]>
Cc: PostgreSQL mailing lists <[email protected]>
Subject: Re: Rewriting the test of pg_upgrade as a TAP test
Date: Fri, 14 Apr 2017 08:24:18 -0400
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAB7nPqRZXui-Z6zaFiSc0HxSwev7Rhi=P4R-_qm_0fUvNy+emQ@mail.gmail.com>
References: <CAB7nPqQKUoV6Vce4Ba9OTf8KA7n96rPM_EOD665hGHmaGFerDg@mail.gmail.com>
	<CAOuzzgoTyw+tW063W4A_UAj9SAqtHBTqgU_cE-4eGSS7V7kK_g@mail.gmail.com>
	<CAB7nPqS2Xj8Zs48mk7NjtKQa69Of3wtGJ+tKpgs2A-Ne9Zy4ww@mail.gmail.com>
	<[email protected]>
	<CAB7nPqToUk6z=+jk11rNiEShoL5963Jwx4jg+svKuKHvZ3hhtQ@mail.gmail.com>
	<[email protected]>
	<CAB7nPqTEV-N_nxE3UyP5bMNz1gd0om2zCTyut+Ohc4+dwRESgA@mail.gmail.com>
	<CAB7nPqTxoNiC62NSTwjk6nb62wf0C20x1QtBnpGdHNn6r=3dZw@mail.gmail.com>
	<[email protected]>
	<CAB7nPqRZXui-Z6zaFiSc0HxSwev7Rhi=P4R-_qm_0fUvNy+emQ@mail.gmail.com>
List-Unsubscribe: <mailto:[email protected]?body=unsub%20pgsql-hackers>

* Michael Paquier ([email protected]) wrote:
> On Fri, Apr 14, 2017 at 8:03 PM, Stephen Frost <[email protected]> wrote:
> > Some of those were specifically left around to test those code paths.
> > I'm not sure if these were those or not though, Andrew was the one who
> > reviewed the various pg_dumpall calls to add --no-sync in places.
> 
> Well, Andrew has pushed the patch I have written, and the calls of
> pg_dumpall in pg_upgrade use --no-sync. The ones intentionally left
> are in src/bin/pg_dump/t/002_pg_dump.pl.

Ok. :)

Thanks!

Stephen


Attachments:

  [application/pgp-signature] signature.asc (819B, ../[email protected]/2-signature.asc)
  download

view thread (113+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Rewriting the test of pg_upgrade as a TAP test
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox