From: Stephen Frost <sfrost@snowman.net>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: WITH clause in CREATE STATISTICS
Date: Wed, 3 May 2017 13:41:48 -0400
Message-ID: <20170503174148.GA21223@tamriel.snowman.net> (raw)
In-Reply-To: <20170503172746.rwftidszir67sgk7@alvherre.pgsql>
References: <20170503151801.4u46436mc64r2bfa@alvherre.pgsql>
<20170503172746.rwftidszir67sgk7@alvherre.pgsql>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Alvaro,
* Alvaro Herrera (alvherre@2ndquadrant.com) wrote:
> Alvaro Herrera wrote:
>
> > In the meantime, I noticed that pg_dump support for extstats is not
> > covered, which I'll go fix next.
>
> Here I add one, which seems to work for me.
>
> Considering that Stephen missed a terminating semicolon for test with
> create_order 96 (the last one prior to my commit) in commit
> 31a8b77a9244, I propose that we change whatever is concatenating those
> strings append a terminating semicolon. (Surely we don't care about two
> tests stanzas writing a single SQL command by omitting the semicolon
> terminator.)
Whoops, sorry about that. Yes, we could pretty easily add that. The
create SQL is built up at the bottom of 002_pg_dump.pl:
$create_sql .= $tests{$test}->{create_sql};
> I wonder if there's any rationale to the create_order numbers. Surely
> we only care for objects that depend on others.
Yes, it was just a way to manage those dependencies. If there's value
in doing something more complicated then we could certainly do that, but
I'm not sure why it would be necessary to add that complexity.
Thanks!
Stephen
Attachments:
[application/pgp-signature] signature.asc (818B, ../20170503174148.GA21223@tamriel.snowman.net/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, alvherre@2ndquadrant.com, simon@2ndquadrant.com, tomas.vondra@2ndquadrant.com
Subject: Re: WITH clause in CREATE STATISTICS
In-Reply-To: <20170503174148.GA21223@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox