From: Noah Misch <noah@leadboat.com>
To: peter.eisentraut@2ndquadrant.com
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Petr Jelinek <petr.jelinek@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Subject: Re: logical replication syntax (was DROP SUBSCRIPTION, query cancellations and slot handling)
Date: Sun, 7 May 2017 08:23:10 +0000
Message-ID: <20170507082310.GL843225@rfd.leadboat.com> (raw)
In-Reply-To: <CA+TgmoYe8_FZ9oNTxL-q42kUXGKCDrrG512qbyKAQw9ROBvQ9g@mail.gmail.com>
References: <CA+TgmoZmkbpAWRzVKDVcHnTBkYjJEFS8=09RL-G3zgdozCLFHQ@mail.gmail.com>
<27478.1493727233@sss.pgh.pa.us>
<cacf7538-5658-a93f-c03a-83d309ed1d9a@2ndquadrant.com>
<CA+TgmoYe8_FZ9oNTxL-q42kUXGKCDrrG512qbyKAQw9ROBvQ9g@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On Tue, May 02, 2017 at 01:42:37PM -0400, Robert Haas wrote:
> On Tue, May 2, 2017 at 8:45 AM, Petr Jelinek
> <petr.jelinek@2ndquadrant.com> wrote:
> > I am happy to implement something different, it's quite trivial to
> > change. But I am not going to propose anything different as I can't
> > think of better syntax (if I could I would have done it). I don't like
> > the OFF or FALSE (ie DROP SLOT OFF) any more than what is there now and
> > it also seems to not map very well to action (as opposed to output
> > option as it is in EXPLAIN). It might not be very close to SQL way but
> > that's because SQL way would be do not do any of those default actions
> > unless they are actually asked for (ie NODROP SLOT would be default and
> > DROP SLOT would be the option) but that's IMHO less user friendly.
>
> So the cases where this "NO" prefixing comes up are:
>
> 1. CREATE SUBSCRIPTION
...
> 2. ALTER SUBSCRIPTION
...
> 3. DROP SUBSCRIPTION
...
> 4. CREATE PUBLICATION
...
> So it doesn't actually look hard to get rid of all of the NO prefixes.
[Action required within three days. This is a generic notification.]
The above-described topic is currently a PostgreSQL 10 open item. Peter,
since you committed the patch believed to have created it, you own this open
item. If some other commit is more relevant or if this does not belong as a
v10 open item, please let us know. Otherwise, please observe the policy on
open item ownership[1] and send a status update within three calendar days of
this message. Include a date for your subsequent status update. Testers may
discover new open items at any time, and I want to plan to get them all fixed
well in advance of shipping v10. Consequently, I will appreciate your efforts
toward speedy resolution. Thanks.
[1] https://www.postgresql.org/message-id/20170404140717.GA2675809%40tornado.leadboat.com
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, peter.eisentraut@2ndquadrant.com, robertmhaas@gmail.com, petr.jelinek@2ndquadrant.com, tgl@sss.pgh.pa.us, michael.paquier@gmail.com
Subject: Re: logical replication syntax (was DROP SUBSCRIPTION, query cancellations and slot handling)
In-Reply-To: <20170507082310.GL843225@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox