From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Kunshchikov Vladimir <Vladimir.Kunshchikov@infotecs.ru>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: [patch] pg_dump/pg_restore zerror() and strerror() mishap
Date: Thu, 22 Jun 2017 11:40:04 -0400
Message-ID: <20170622154004.e6bcw6juk2pwhngb@alvherre.pgsql> (raw)
In-Reply-To: <1498120508308.9826@infotecs.ru>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Kunshchikov Vladimir wrote:
Hi,
> our testing team has noticed apparently wrong backup/restore error messages like this:
>
>
> pg_restore: [compress_io] could not read from input file: success
> pg_dump: [directory archiver] could not write to output file: success
>
>
>
> Such "success" messages are caused by calling strerror() after gzread()/gzwrite() failures.
Yeah, I've complained about this before but never got around to actually
fixing it. Thanks for the patch, I'll see about putting it on all
branches soon.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, Vladimir.Kunshchikov@infotecs.ru
Subject: Re: [patch] pg_dump/pg_restore zerror() and strerror() mishap
In-Reply-To: <20170622154004.e6bcw6juk2pwhngb@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox