From: Bruce Momjian <bruce@momjian.us>
To: Sergey Burladyan <eshkinkot@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Dmitriy Sarafannikov <dsarafannikov@yandex.ru>
Cc: Vladimir Borodin <root@simply.name>
Subject: Re: Broken hint bits (freeze)
Date: Thu, 29 Jun 2017 20:56:34 -0400
Message-ID: <20170630005634.GA4448@momjian.us> (raw)
In-Reply-To: <20170629021135.GD16576@momjian.us>
References: <20170620025919.GA28277@momjian.us>
<20170620033726.GB28277@momjian.us>
<87h8zb6kbx.fsf@seb.koffice.internal>
<CAA4eK1JmEAj9qUMbS-=u7b4Boqsr3mAoadevT9LDWm4JgxamBg@mail.gmail.com>
<8760fq7pfe.fsf@seb.koffice.internal>
<CAA4eK1JxV1+UTyU3T2WM6rhiDEZy6zk3cx+Y3TaXCXAwQxcU1Q@mail.gmail.com>
<CAA4eK1+o6ErVAh484VtE91wow1-uOysohSvb0TS52Ei76PzOKg@mail.gmail.com>
<20170621163356.GB9358@momjian.us>
<87lgoi68dg.fsf@seb.koffice.internal>
<20170629021135.GD16576@momjian.us>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On Wed, Jun 28, 2017 at 10:11:35PM -0400, Bruce Momjian wrote:
> On Fri, Jun 23, 2017 at 06:17:47PM +0300, Sergey Burladyan wrote:
> > PS:
> > I successfully upgraded last night from 9.2 to 9.4 and find other issue :-)
> >
> > It is about hash index and promote:
> > 1. create master
> > 2. create standby from it
> > 3. create unlogged table and hash index like:
> > create unlogged table test (id int primary key, v text);
> > create index on test using hash (id);
> > 3. stop master
> > 4. promote standby
> >
> > now, if you try to upgrade this new promoted master pg_upgrade will stop
> > on this hash index:
> > error while creating link for relation "public.test_id_idx" ("s/9.2/base/16384/16393" to "m/9.4/base/16422/16393"): No such file or directory
> > Failure, exiting
> >
> > I touch this file (s/9.2/base/16384/16393) and rerun pg_upgrade from
> > scratch and it complete successfully.
>
> Sergey, can you please test if the table "test" is not unlogged, does
> pg_upgrade still fail on the hash index file?
I was able to reproduce this failure on my server. :-)
What I found is that the problem is larger than I thought. Sergey is
correct that pg_upgrade fails because there is no hash file associated
with the unlogged table, but in fact a simple access of the unlogged
table with a hash index generates an error:
test=> SELECT * FROM t_u_hash;
ERROR: could not open file "base/16384/16392": No such file or directory
What is interesting is that this is the only combination that generates
an error. A unlogged able with a btree index or a logged table with a
hash index are fine, e.g.:
List of relations
Schema | Name | Type | Owner
--------+-----------+-------+----------
public | t_btree | table | postgres
public | t_hash | table | postgres
public | t_u_btree | table | postgres
fail--> public | t_u_hash | table | postgres
This doesn't fail on PG 10 since we WAL-log hash indexes.
I think we have two questions:
1. do we fix this in the server
2. if not, do we fix pg_upgrade
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ As you are, so once was I. As I am, so you will be. +
+ Ancient Roman grave inscription +
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bruce@momjian.us, eshkinkot@gmail.com, amit.kapila16@gmail.com, dsarafannikov@yandex.ru, root@simply.name
Subject: Re: Broken hint bits (freeze)
In-Reply-To: <20170630005634.GA4448@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox