From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: a.akenteva@postgrespro.ru
Cc: pgsql-hackers@postgresql.org
Subject: Re: A weird bit in pg_upgrade/exec.c
Date: Thu, 9 Nov 2017 17:06:08 +0100
Message-ID: <20171109160608.ix24ajduhlzeiz44@alvherre.pgsql> (raw)
In-Reply-To: <f9266a85d918a3cf3a386b5148aee666@postgrespro.ru>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
a.akenteva@postgrespro.ru wrote:
> This function has two calls:
> check_bin_dir(&old_cluster);
> check_bin_dir(&new_cluster);
>
> I'd like to substitute these last two lines with this:
> get_bin_version(cluster);
Odd indeed. One would think that if a cluster variable is passed as
parameter, the global vars should not be used. +1 for fixing it, and
your proposal sounds as good as any.
> Doing it would simplify the patch I'm writing, but I'm worried I might break
> something that's been there for a long time and has been working fine.
I think odd coding this was introduced recently because of the
pg_resetxlog -> pg_resetwal renaming.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, a.akenteva@postgrespro.ru
Subject: Re: A weird bit in pg_upgrade/exec.c
In-Reply-To: <20171109160608.ix24ajduhlzeiz44@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox