From: Steve Singer <steve@ssinger.info>
To: pgsql-hackers@postgresql.org
Cc: Fabien Coelho <postgresql.org@coelho.net>
Subject: Re: pgbench regression test failure
Date: Sun, 12 Nov 2017 02:47:39 +0000
Message-ID: <20171112024739.23750.54311.pgcf@coridan.postgresql.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1709240820160.4999@lancre>
References: <26654.1505232433@sss.pgh.pa.us>
<alpine.DEB.2.20.1709240820160.4999@lancre>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
The following review has been posted through the commitfest application:
make installcheck-world: tested, failed
Implements feature: not tested
Spec compliant: not tested
Documentation: not tested
This causes the pgbench tests to fail (consistently) with
not ok 194 - pgbench late throttling stdout /(?^:processed: [01]/10)/
When I run pgbench manually I get (-t 10 --rate=100000 --latency-limit=1 -n -r)
number of transactions actually processed: 10/10
number of transactions skipped: 10 (100.000 %)
Prior to the patch I was getting.
number of transactions actually processed: 0/10
number of transactions skipped: 10 (100.000 %)
@@ -3539,7 +3542,7 @@ printResults(TState *threads, StatsData *total, instr_time total_time,^M
{^M
printf("number of transactions per client: %d\n", nxacts);^M
printf("number of transactions actually processed: " INT64_FORMAT "/%d\n",^M
- total->cnt - total->skipped, nxacts * nclients);^M
+ total->cnt, nxacts * nclients);^M
I think you want ntx instead of total->cnt here.
The new status of this patch is: Waiting on Author
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: steve@ssinger.info, postgresql.org@coelho.net
Subject: Re: pgbench regression test failure
In-Reply-To: <20171112024739.23750.54311.pgcf@coridan.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox