From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Maksim Milyutin <milyutinma@gmail.com>
Subject: Re: [HACKERS] Proposal: Local indexes for partitioned table
Date: Tue, 14 Nov 2017 15:40:08 +0100
Message-ID: <20171114144008.mlmuulkzlxacnelc@alvherre.pgsql> (raw)
In-Reply-To: <CANP8+jLfAZLCjgPD7gwnac=1=NQ-5f4WOcDwunzqBNgD=OihTg@mail.gmail.com>
Simon Riggs wrote:
> On 13 November 2017 at 12:55, Alvaro Herrera <alvherre@alvh.no-ip.org> wrote:
> > Somehow I managed to include an unrelated patch as attachment. Here's
> > another attempt (on which I also lightly touched ddl.sgml with relevant
> > changes).
>
> Looks good. Some minor comments below.
>
> 0001- Simplify
> Seems useful as separate step; agree with everything, no further comments
Thanks, pushed.
> Why uint16? Why not just uint?
*Shrug*. 16 bits seem plenty enough. I changed it to bits16, which we
use in other places for bitmasks.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, simon@2ndquadrant.com, robertmhaas@gmail.com, milyutinma@gmail.com
Subject: Re: [HACKERS] Proposal: Local indexes for partitioned table
In-Reply-To: <20171114144008.mlmuulkzlxacnelc@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox