From: Aleksander Alekseev <a.alekseev@postgrespro.ru>
To: pgsql-hackers@postgresql.org
Cc: Anthony Bykov <a.bykov@postgrespro.ru>
Subject: Re: Transform for pl/perl
Date: Wed, 15 Nov 2017 08:58:54 +0000
Message-ID: <20171115085854.1377.37552.pgcf@coridan.postgresql.org> (raw)
In-Reply-To: <CAFj8pRA0ZhFH_G8Z_xagygbdZYbmX0NE74tTQd+=qD0=XDZYgQ@mail.gmail.com>
References: <20171024140129.6bd01f68@anthony-24-g082ur>
<CAFj8pRA0ZhFH_G8Z_xagygbdZYbmX0NE74tTQd+=qD0=XDZYgQ@mail.gmail.com>
The following review has been posted through the commitfest application:
make installcheck-world: tested, passed
Implements feature: tested, passed
Spec compliant: tested, passed
Documentation: tested, passed
Hello Anthony,
Great patch! Everything is OK and I almost agree with Pavel.
The only thing that I would like to suggest is to add a little more tests for
various corner cases. For instance:
1. Converting in both directions (Perl <-> JSONB) +/- infinity, NaN, MAX_INT,
MIN_INT.
2. Converting in both directions strings that contain non-ASCII (Russian /
Japanese / etc) characters and special characters like \n, \t, \.
3. Make sure that converting Perl objects that are not representable in JSONB
(blessed hashes, file descriptors, regular expressions, ...) doesn't crash
everything and shows a reasonable error message.
The new status of this patch is: Waiting on Author
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.alekseev@postgrespro.ru, a.bykov@postgrespro.ru
Subject: Re: Transform for pl/perl
In-Reply-To: <20171115085854.1377.37552.pgcf@coridan.postgresql.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox