pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Christoph Berg <christoph.berg@credativ.de>
To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Reproducible builds: genbki.pl vs schemapg.h
Date: Fri, 15 Dec 2017 11:22:23 +0100
Message-ID: <20171215102223.GB31812@msg.df7cb.de> (raw)

Hi,

Debian's reproducible builds project has revealed that the full build
path gets embedded into server/catalog/schemapg.h:

/*-------------------------------------------------------------------------
 *
 * schemapg.h
 *    Schema_pg_xxx macros for use by relcache.c
 *
 * Portions Copyright (c) 1996-2017, PostgreSQL Global Development Group
 * Portions Copyright (c) 1994, Regents of the University of California
 *
 * NOTES
 *  ******************************
 *  *** DO NOT EDIT THIS FILE! ***
 *  ******************************
 *
 *  It has been GENERATED by /build/postgresql-11-05gRdu/build/../src/backend/catalog/genbki.pl
 *
 *-------------------------------------------------------------------------
 */

This information will vary on rebuilding the binaries, needlessly
causing different checksums.

I'm proposing to strip that down to "It has been GENERATED genbki.pl".
Patch attached.

Christoph

Attachments:

reproducible-genbki.patch (text/x-diff, 674B) download
diff --git a/src/backend/catalog/genbki.pl b/src/backend/catalog/genbki.pl
new file mode 100644
index 256a9c9..30153e6
*** a/src/backend/catalog/genbki.pl
--- b/src/backend/catalog/genbki.pl
*************** print $schemapg <<EOM;
*** 340,346 ****
   *  *** DO NOT EDIT THIS FILE! ***
   *  ******************************
   *
!  *  It has been GENERATED by $0
   *
   *-------------------------------------------------------------------------
   */
--- 340,346 ----
   *  *** DO NOT EDIT THIS FILE! ***
   *  ******************************
   *
!  *  It has been GENERATED by genbki.pl
   *
   *-------------------------------------------------------------------------
   */

view thread (9+ messages)  latest in thread

Message-ID: <20171215102223.GB31812@msg.df7cb.de>
Permalink:  ../20171215102223.GB31812@msg.df7cb.de/
Also on:    postgresql.org/message-id/20171215102223.GB31812@msg.df7cb.de

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: christoph.berg@credativ.de
  Subject: Re: Reproducible builds: genbki.pl vs schemapg.h
  In-Reply-To: <20171215102223.GB31812@msg.df7cb.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox