pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: Ildus Kurbangaliev <i.kurbangaliev@postgrespro.ru>
To: Ildar Musin <i.musin@postgrespro.ru>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Евгений Шишкин <itparanoia@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Oleg Bartunov <obartunov@gmail.com>
Cc: Craig Ringer <craig@2ndquadrant.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: Chapman Flack <chap@anastigmatix.net>
Subject: Re: [HACKERS] Custom compression methods
Date: Mon, 29 Jan 2018 19:04:03 +0300
Message-ID: <20180129190403.3eb59d4a@wp.localdomain> (raw )
In-Reply-To: <a8c68897-bc6c-c21a-d498-2c56b8373b2c@postgrespro.ru >
References: <20171201194859.le5hvnnrjzhxhm2t@alvherre.pgsql >
<20171211155555.05ddd2fc@postgrespro.ru >
<CA+Tgmoa7U9Pgc8YV-eRkKAK2s74aL6Yw1Wsj81PTjyrn0Eg99g@mail.gmail.com >
<CAPpHfdsO0wSy6ZEoOQS5AkxTRXeCzv4uz=S8hOOJNgOxPmJW4A@mail.gmail.com >
<CA+TgmoYqG2DFHDEM9ixMQA0p9d=_w6pYaa-+Jue4PP56VNSCWQ@mail.gmail.com >
<CAPpHfduP77qxdETcPRc_FGOVJpeSCwNGoSUgNU3BCHXu57RVMA@mail.gmail.com >
<CA+TgmoZqJYP+othk0c-r6acjVWWvBoxkWm5eHLUE=8VyezQKKw@mail.gmail.com >
<20171213151818.75a20259@postgrespro.ru >
<CA+TgmoZ68LyL0rFPDgC1J-6p9ZQZc2xS4Txd-9661s+w6_MwBg@mail.gmail.com >
<20171218115431.2b3e29ba@wp.localdomain >
<20180115024930.48583c69@hh >
<0633c6e5-5328-5c5b-708b-c4409e3fd131@postgrespro.ru >
<20180123160454.131ade09@wp.localdomain >
<6fd5dea3-8889-c7bb-9df2-79493b2b6ab0@postgrespro.ru >
<20180125172457.5967c022@wp.localdomain >
<bc430af2-4388-4ad3-acda-f1a95b9310ae@postgrespro.ru >
<20180129144452.08f04dc3@wp.localdomain >
<a8c68897-bc6c-c21a-d498-2c56b8373b2c@postgrespro.ru >
On Mon, 29 Jan 2018 17:29:29 +0300
Ildar Musin <i.musin@postgrespro.ru> wrote:
>
> Patch applies cleanly, builds without any warnings, documentation
> builds ok, all tests pass.
>
> A remark for the committers. The patch is quite big, so I really wish
> more reviewers looked into it for more comprehensive review. Also a
> native english speaker should check the documentation and comments.
> Another thing is that tests don't cover cmdrop method because the
> built-in pglz compression doesn't use it (I know there is an jsonbd
> extension [1] based on this patch and which should benefit from
> cmdrop method, but it doesn't test it either yet).
>
> I think I did what I could and so passing this patch to committers
> for the review. Changed status to "Ready for committer".
>
>
> [1] https://github.com/postgrespro/jsonbd
>
Thank you!
About cmdrop, I checked that's is called manually, but going to check
it thoroughly in my extension.
--
---
Ildus Kurbangaliev
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
view thread (430+ messages) latest in thread
Message-ID: <20180129190403.3eb59d4a@wp.localdomain>
Permalink: ../20180129190403.3eb59d4a@wp.localdomain/
Also on: postgresql.org/message-id/20180129190403.3eb59d4a@wp.localdomain
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: i.kurbangaliev@postgrespro.ru, i.musin@postgrespro.ru, robertmhaas@gmail.com, a.korotkov@postgrespro.ru, tomas.vondra@2ndquadrant.com, alvherre@2ndquadrant.com, itparanoia@gmail.com, andres@anarazel.de, obartunov@gmail.com, craig@2ndquadrant.com, peter.eisentraut@2ndquadrant.com, chap@anastigmatix.net
Subject: Re: [HACKERS] Custom compression methods
In-Reply-To: <20180129190403.3eb59d4a@wp.localdomain>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox