From: Stephen Frost <sfrost@snowman.net>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: Ivan Kartyshov <i.kartyshov@postgrespro.ru>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] make async slave to wait for lsn to be replayed
Date: Fri, 2 Feb 2018 04:02:04 -0500
Message-ID: <20180202090204.GQ2416@tamriel.snowman.net> (raw)
In-Reply-To: <CANP8+j+ELxyoVECyYagioUUkYTkJCiZwzPHc4S9V0LJS9r5GNw@mail.gmail.com>
References: <0240c26c-9f84-30ea-fca9-93ab2df5f305@postgrespro.ru>
<CAEepm=105OCnhe9cAdYp0Vy1b2VmQFX6n9qM+nx70GXUKgjF9A@mail.gmail.com>
<c585d9a0-5bda-778e-e628-dd30959d71d3@postgrespro.ru>
<CAPpHfdvUnqY8TTwZ4gMOcwY+3S+N=07gpuL61p41E6SdAetvCg@mail.gmail.com>
<abcff0b4e3ce1c2a4d14f54e7031dc15@postgrespro.ru>
<CA+CSw_uW2yVMMvQ8S2hAfbobXSDhCF0uBZ3zjYL650Z=-0PkFQ@mail.gmail.com>
<de402dc80e39c358dedf174c13bb5226@postgrespro.ru>
<20180122232100.GZ2416@tamriel.snowman.net>
<CANP8+j+ELxyoVECyYagioUUkYTkJCiZwzPHc4S9V0LJS9r5GNw@mail.gmail.com>
Greetings,
* Simon Riggs (simon@2ndquadrant.com) wrote:
> On 22 January 2018 at 23:21, Stephen Frost <sfrost@snowman.net> wrote:
>
> >> It sounds reasonable. I can offer the following version.
> >>
> >> WAIT LSN lsn_number;
> >> WAIT LSN lsn_number TIMEOUT delay;
> >> WAIT LSN lsn_number INFINITE;
> >> WAIT LSN lsn_number NOWAIT;
> >>
> >>
> >> WAIT [token] wait_value [option];
> >>
> >> token - [LSN, TIME | TIMESTAMP | CSN | XID]
> >> option - [TIMEOUT | INFINITE | NOWAIT]
> >>
> >> Ready to listen to your suggestions.
> >
> > There were a few different suggestions made, but somehow this thread
> > ended up in Needs Review again while still having LSNs. I've changed it
> > back to Waiting for Author since it seems pretty unlikely that using LSN
> > is going to be acceptable based on the feedback.
>
> I agree with the need for a separate command rather than a function.
>
> I agree that WAIT LSN is good syntax because this allows us to wait
> for something else in future.
>
> Without having reviewed the patch, I think we want this feature in PG11.
I've also looked back through this and while I understand the up-thread
discussion about having something better than LSN, I don't see any
particular reason to not allow waiting on LSN, so I agree with Simon
that this makes sense to include. There are definite cases it helps
with today and it doesn't block off future work.
As we're closing out the January commitfest, I've moved this to the next
one.
Thanks!
Stephen
Attachments:
[application/pgp-signature] signature.asc (818B, ../20180202090204.GQ2416@tamriel.snowman.net/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, simon@2ndquadrant.com, i.kartyshov@postgrespro.ru
Subject: Re: [HACKERS] make async slave to wait for lsn to be replayed
In-Reply-To: <20180202090204.GQ2416@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox