From: Aleksander Alekseev <a.alekseev@postgrespro.ru>
To: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Yugo Nagata <nagata@sraoss.co.jp>
Cc: pgsql-hackers@postgresql.org
Subject: Re: CURRENT OF causes an error when IndexOnlyScan is used
Date: Tue, 20 Feb 2018 12:52:53 +0300
Message-ID: <20180220095252.GA18315@e733.localdomain> (raw)
In-Reply-To: <97dc81d3-0ea9-3032-49d9-7983e35fb010@postgrespro.ru>
References: <20180201013349.937dfc5f.nagata@sraoss.co.jp>
<20180201014444.f78358df.nagata@sraoss.co.jp>
<22958.1517451171@sss.pgh.pa.us>
<97dc81d3-0ea9-3032-49d9-7983e35fb010@postgrespro.ru>
Hi Anastasia,
> I'd like to propose the patch that fixes the issue.
> We already have a way to return heaptuple from IndexOnlyScan,
> but it was not applied to b-tree for some reason.
>
> Attached patch solves the reported bug.
> Moreover, it will come in handy for "index with included attributes" feature
> [1],
> where we can store long (and even TOASTed) attributes in indextuple.
>
> [1] https://commitfest.postgresql.org/17/1350/
I believe the patch should include a test that tries to reproduce an
issue it tries to fix.
Also maybe this code that repeats 3 times can be moved to a separate
procedure?
--
Best regards,
Aleksander Alekseev
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.alekseev@postgrespro.ru, a.lubennikova@postgrespro.ru, tgl@sss.pgh.pa.us, nagata@sraoss.co.jp
Subject: Re: CURRENT OF causes an error when IndexOnlyScan is used
In-Reply-To: <20180220095252.GA18315@e733.localdomain>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox