From: Arthur Zakirov <a.zakirov@postgrespro.ru>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Subject: Re: pg_get_functiondef forgets about most GUC_LIST_INPUT GUCs
Date: Tue, 20 Feb 2018 18:46:57 +0300
Message-ID: <20180220154656.GA7518@zakirov.localdomain> (raw)
In-Reply-To: <20180112012440.GA2222@paquier.xyz>
References: <20180111064900.GA51030@paquier.xyz>
<13647.1515685358@sss.pgh.pa.us>
<20180112012440.GA2222@paquier.xyz>
Hello,
On Fri, Jan 12, 2018 at 10:24:40AM +0900, Michael Paquier wrote:
> OK, I can live with that. What do you think about the attached? I'll be
> happy to produce patches for back-branches as necessary. When an option
> is not found, I have made the function return 0 as value for the flags,
> which is consistent with flatten_set_variable_args(). To make things
> behave more consistently with GUC_LIST_QUOTE GUCs, it seems to me that
> those should not be quoted as well (ALTER SYSTEM shares the same
> compatibility). And attached is a patch.
Just 2 cents from me. It seems that there is a problem with extensions
GUCs. For example:
=# CREATE FUNCTION func_with_set_params() RETURNS integer
AS 'select 1;'
LANGUAGE SQL
set plpgsql.extra_errors to 'shadowed_variables';
=# SELECT pg_get_functiondef('func_with_set_params'::regproc);
pg_get_functiondef
----------------------------------------------------------
CREATE OR REPLACE FUNCTION public.func_with_set_params()+
RETURNS integer +
LANGUAGE sql +
SET "plpgsql.extra_errors" TO 'shadowed_variables' +
AS $function$select 1;$function$ +
It is good while plpgsql is loaded. But when we exit the session and try
it again in another:
=# SELECT pg_get_functiondef('func_with_set_params'::regproc);
ERROR: unrecognized configuration parameter "plpgsql.extra_errors"
--
Arthur Zakirov
Postgres Professional: http://www.postgrespro.com
Russian Postgres Company
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: a.zakirov@postgrespro.ru, michael.paquier@gmail.com, tgl@sss.pgh.pa.us
Subject: Re: pg_get_functiondef forgets about most GUC_LIST_INPUT GUCs
In-Reply-To: <20180220154656.GA7518@zakirov.localdomain>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox