From: Michael Paquier <michael@paquier.xyz>
To: Arthur Zakirov <a.zakirov@postgrespro.ru>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: tgl@sss.pgh.pa.us
Cc: pavel.stehule@gmail.com
Cc: michael.paquier@gmail.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: pg_get_functiondef forgets about most GUC_LIST_INPUT GUCs
Date: Fri, 16 Mar 2018 10:21:39 +0900
Message-ID: <20180316012139.GD2666@paquier.xyz> (raw)
In-Reply-To: <20180315103350.GA29606@zakirov.localdomain>
References: <22193.1521088405@sss.pgh.pa.us>
<20180315.140315.106707419.horiguchi.kyotaro@lab.ntt.co.jp>
<20180315060954.GE617@paquier.xyz>
<20180315.184836.185034889.horiguchi.kyotaro@lab.ntt.co.jp>
<20180315103350.GA29606@zakirov.localdomain>
On Thu, Mar 15, 2018 at 01:33:51PM +0300, Arthur Zakirov wrote:
> I think your approach has a vulnerability too. I believe that a
> non GUC_LIST_INPUT extension GUC which was used to create a function may
> become GUC_LIST_INPUT variable. If I'm not mistaken nothing stops from
> that. In this case values in proconfigislist won't be valide anymore.
I don't understand what you mean here. Are you referring to a custom
GUC which was initially declared as not being a list, but became a list
after a plugin upgrade with the same name? Isn't the author to blame in
this case?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, a.zakirov@postgrespro.ru, horiguchi.kyotaro@lab.ntt.co.jp, tgl@sss.pgh.pa.us, pavel.stehule@gmail.com, michael.paquier@gmail.com
Subject: Re: pg_get_functiondef forgets about most GUC_LIST_INPUT GUCs
In-Reply-To: <20180316012139.GD2666@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox