From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Jesper Pedersen <jesper.pedersen@redhat.com>
Cc: Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>
Cc: Beena Emerson <memissemerson@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: amul sul <sulamul@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Subject: Re: [HACKERS] Runtime Partition Pruning
Date: Sat, 7 Apr 2018 09:23:49 -0300
Message-ID: <20180407122349.6ngjpkf67zs3vmnd@alvherre.pgsql> (raw)
In-Reply-To: <CA+HiwqGzq4D6z=8R0AP+XhbTFCQ-4Ct+t2ekqjE9Fpm84_JUGg@mail.gmail.com>
Amit Langote wrote:
> See if the attached makes it any better.
>
> Now I know we don't have the runtime pruning in yet, but since the
> proposed patch would extend its functionality I have included its
> description in the comment.
Thanks!
I edited it as attached, to 1. avoid mentioning functionality that
doesn't yet exist, and 2. avoid excessive internal detail (we want a
high-level overview here), which from experience gets outdated pretty
quickly.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
commit 28768290d8d9c58e76e2594a14d5b1f8465ba262[m
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
AuthorDate: Sat Apr 7 08:44:12 2018 -0300
CommitDate: Sat Apr 7 09:20:58 2018 -0300
Add some documentation to partprune.c
Author: Amit Langote
Discussion: https://postgr.es/m/CA+HiwqGzq4D6z=8R0AP+XhbTFCQ-4Ct+t2ekqjE9Fpm84_JUGg@mail.gmail.comdiff --git a/src/backend/partitioning/partprune.c b/src/backend/partitioning/partprune.cindex 959ee1643d..07b8057e3f 100644--- a/src/backend/partitioning/partprune.c+++ b/src/backend/partitioning/partprune.c@@ -1,10 +1,27 @@
/*-------------------------------------------------------------------------
*
* partprune.c
- * Parses clauses attempting to match them up to partition keys of a- * given relation and generates a set of "pruning steps", which can be- * later "executed" either from the planner or the executor to determine- * the minimum set of partitions which match the given clauses.+ * Support for partition pruning during query planning+ *+ * This module implements partition pruning using the information contained in+ * table's partition descriptor and query clauses.+ *+ * During planning, clauses that can be matched to the table's partition key+ * are turned into a set of "pruning steps", which are then executed to+ * produce a set of RTIs of partitions whose bounds satisfy the constraints in+ * the step. Partitions not in the set are said to have been pruned.+ *+ * There are two kinds of pruning steps: a "base" pruning step, which contains+ * information extracted from one or more clauses that are matched to the+ * (possibly multi-column) partition key, such as the expressions whose values+ * to match against partition bounds and operator strategy to associate to+ * each expression. The other kind is a "combine" pruning step, which combines+ * the outputs of some other steps using the appropriate combination method.+ * All steps that are constructed are executed in succession such that for any+ * "combine" step, all of the steps whose output it depends on are executed+ * first and their ouput preserved.+ *+ * See gen_partprune_steps_internal() for more details on step generation.
*
* Portions Copyright (c) 1996-2018, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California
Attachments:
[text/plain] expand-partprune-header-comment-2.patch (2.3K, ../20180407122349.6ngjpkf67zs3vmnd@alvherre.pgsql/2-expand-partprune-header-comment-2.patch)
download | inline diff:
commit 28768290d8d9c58e76e2594a14d5b1f8465ba262[m
Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
AuthorDate: Sat Apr 7 08:44:12 2018 -0300
CommitDate: Sat Apr 7 09:20:58 2018 -0300
Add some documentation to partprune.c
Author: Amit Langote
Discussion: https://postgr.es/m/CA+HiwqGzq4D6z=8R0AP+XhbTFCQ-4Ct+t2ekqjE9Fpm84_JUGg@mail.gmail.com
diff --git a/src/backend/partitioning/partprune.c b/src/backend/partitioning/partprune.cindex 959ee1643d..07b8057e3f 100644--- a/src/backend/partitioning/partprune.c+++ b/src/backend/partitioning/partprune.c@@ -1,10 +1,27 @@
/*-------------------------------------------------------------------------
*
* partprune.c
- * Parses clauses attempting to match them up to partition keys of a- * given relation and generates a set of "pruning steps", which can be- * later "executed" either from the planner or the executor to determine- * the minimum set of partitions which match the given clauses.+ * Support for partition pruning during query planning+ *+ * This module implements partition pruning using the information contained in+ * table's partition descriptor and query clauses.+ *+ * During planning, clauses that can be matched to the table's partition key+ * are turned into a set of "pruning steps", which are then executed to+ * produce a set of RTIs of partitions whose bounds satisfy the constraints in+ * the step. Partitions not in the set are said to have been pruned.+ *+ * There are two kinds of pruning steps: a "base" pruning step, which contains+ * information extracted from one or more clauses that are matched to the+ * (possibly multi-column) partition key, such as the expressions whose values+ * to match against partition bounds and operator strategy to associate to+ * each expression. The other kind is a "combine" pruning step, which combines+ * the outputs of some other steps using the appropriate combination method.+ * All steps that are constructed are executed in succession such that for any+ * "combine" step, all of the steps whose output it depends on are executed+ * first and their ouput preserved.+ *+ * See gen_partprune_steps_internal() for more details on step generation.
*
* Portions Copyright (c) 1996-2018, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of the University of California
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, amitlangote09@gmail.com, andres@anarazel.de, david.rowley@2ndquadrant.com, Langote_Amit_f8@lab.ntt.co.jp, jesper.pedersen@redhat.com, rajkumar.raghuwanshi@enterprisedb.com, memissemerson@gmail.com, robertmhaas@gmail.com, sulamul@gmail.com, dilipbalaut@gmail.com
Subject: Re: [HACKERS] Runtime Partition Pruning
In-Reply-To: <20180407122349.6ngjpkf67zs3vmnd@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox