From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Pavan Deolasee <pavan.deolasee@gmail.com>
Cc: Etsuro Fujita <fujita.etsuro@lab.ntt.co.jp>
Cc: Andres Freund <andres@anarazel.de>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Cc: Peter Geoghegan <pg@bowt.ie>
Subject: Re: ON CONFLICT DO UPDATE for partitioned tables
Date: Wed, 18 Apr 2018 10:40:07 -0300
Message-ID: <20180418134007.n7vbkwww4e22sg6k@alvherre.pgsql> (raw)
In-Reply-To: <f6c11141-9569-7b0f-eb24-061baef44c9f@lab.ntt.co.jp>
Amit Langote wrote:
> On 2018/04/18 0:04, Alvaro Herrera wrote:
> > Amit Langote wrote:
> >
> >> I just confirmed my hunch that this wouldn't somehow do the right thing
> >> when the OID system column is involved. Like this case:
> >
> > This looks too big a patch to pursue now. I'm inclined to just remove
> > the equalTupdesc changes.
>
> OK. Here is the patch that removes equalTupdesc optimization.
Hmm. If we modify (during pg12, of course -- not now) partition tables
that are created identical to their parent table so that they share the
pg_type row, this would become useful. Unless there a reason why that
change is completely unworkable, I'd just leave it there. (I claim that
it works like that only because it used to work like that, not because
it's impossible to make work the other way.)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, Langote_Amit_f8@lab.ntt.co.jp, pavan.deolasee@gmail.com, fujita.etsuro@lab.ntt.co.jp, andres@anarazel.de, pg@bowt.ie
Subject: Re: ON CONFLICT DO UPDATE for partitioned tables
In-Reply-To: <20180418134007.n7vbkwww4e22sg6k@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox