From: David Fetter <david@fetter.org>
To: John Naylor <jcnaylor@gmail.com>
Cc: Stas Kelvich <s.kelvich@postgrespro.ru>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: unused_oids script is broken with bsd sed
Date: Wed, 25 Apr 2018 16:59:03 +0200
Message-ID: <20180425145902.GT25709@fetter.org> (raw)
In-Reply-To: <CAJVSVGU2w6rvTXghDe7-Y3x9Ca0833VmnC3HpaYKGLw4xznpJA@mail.gmail.com>
References: <37D774E4-FE1F-437E-B3D2-593F314B7505@postgrespro.ru>
<34a54c54-9132-1254-2bc3-d3489fb79728@2ndQuadrant.com>
<4473.1524665917@sss.pgh.pa.us>
<4DE444D1-DDE9-460F-AC2F-EB1B73D94A2D@postgrespro.ru>
<CAJVSVGU2w6rvTXghDe7-Y3x9Ca0833VmnC3HpaYKGLw4xznpJA@mail.gmail.com>
On Wed, Apr 25, 2018 at 09:55:54PM +0700, John Naylor wrote:
> On 4/25/18, Stas Kelvich <s.kelvich@postgrespro.ru> wrote:
> >> On 25 Apr 2018, at 17:18, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >> I think we should rewrite
> >> both of them to use the Catalog.pm infrastructure.
> >
> > Okay, seems reasonable. I'll put shared code in Catalog.pm and
> > update patch.
>
> I don't think you need any new code in Catalog.pm, I believe the
> suggestion was just to use that module as a stable interface to the
> data. Looking at your patch, I'll mention that we have an idiom for
> extracting #define'd OID symbols, e.g.:
>
> my $FirstBootstrapObjectId = Catalog::FindDefinedSymbol(
> 'access/transam.h', \@include_path, 'FirstBootstrapObjectId');
While we're improving things, there's not really a reason this program
should need to be run from any particular spot. It can detect where it
is and act on that information.
Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: david@fetter.org, jcnaylor@gmail.com, s.kelvich@postgrespro.ru, tgl@sss.pgh.pa.us, andrew.dunstan@2ndquadrant.com
Subject: Re: unused_oids script is broken with bsd sed
In-Reply-To: <20180425145902.GT25709@fetter.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox