pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: TRUNCATE tables referenced by FKs on partitioned tables
Date: Thu, 12 Jul 2018 12:29:48 -0400
Message-ID: <20180712162948.znhmcvbvbekji4ow@alvherre.pgsql> (raw)
In-Reply-To: <20180712025308.GA7352@paquier.xyz>

On 2018-Jul-12, Michael Paquier wrote:

> On Wed, Jul 11, 2018 at 06:59:16PM -0400, Alvaro Herrera wrote:
> > Anyway, this patch seems to fix it, and adds what I think is appropriate
> > test coverage.
> 
> This looks good to me.  I am noticing that the documentation of TRUNCATE
> does not mention that when running the command on a partitioned table
> then it automatically gets to the children even if CASCADE is not used
> and each child partition is not listed.

Hmm ... well, that's not new -- I think that came in with pg10.

> What is the filler column added in truncpart used for?

Nothing.  Also column b -- I had an additional different test, but then
I discovered it wasn't testing anything new.  Removed both.

Pushed, thanks for looking!

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




view thread (5+ messages)

Message-ID: <20180712162948.znhmcvbvbekji4ow@alvherre.pgsql>
Permalink:  ../20180712162948.znhmcvbvbekji4ow@alvherre.pgsql/
Also on:    postgresql.org/message-id/20180712162948.znhmcvbvbekji4ow@alvherre.pgsql

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: alvherre@2ndquadrant.com, michael@paquier.xyz
  Subject: Re: TRUNCATE tables referenced by FKs on partitioned tables
  In-Reply-To: <20180712162948.znhmcvbvbekji4ow@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox