From: Michael Paquier <michael@paquier.xyz>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: sk@zsrv.org, Michael Paquier <michael.paquier@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Subject: Re: [HACKERS] Restricting maximum keep segments by repslots
Date: Fri, 20 Jul 2018 13:25:20 +0900
Message-ID: <20180720042520.GD7023@paquier.xyz> (raw)
In-Reply-To: <CAD21AoDayePWwu4t=VPP5P1QFDSBvks1d8j76bXp5rbXoPbZcA@mail.gmail.com>
References: <CAD21AoDiiA4qHj0thqw80Bt=vefSQ9yGpZnr0kuLTXszbrV9iQ@mail.gmail.com>
<20180709.144706.258526585.horiguchi.kyotaro@lab.ntt.co.jp>
<CAD21AoCFtW6+SN_eVTszDAjQeeU2sSea2VpCEx08ejNafk8H9w@mail.gmail.com>
<20180713.174004.249224160.horiguchi.kyotaro@lab.ntt.co.jp>
<CAD21AoDayePWwu4t=VPP5P1QFDSBvks1d8j76bXp5rbXoPbZcA@mail.gmail.com>
On Fri, Jul 20, 2018 at 10:13:58AM +0900, Masahiko Sawada wrote:
> Also, I'm not sure it's a good way to show the distance as LSN. LSN is
> a monotone increasing value but in your patch, a value of the "remain"
> column can get decreased.
If that can happen, I think that this is a very, very bad idea. A
couple of code paths, including segment recycling and the new WAL
advancing rely on such monotonic properties. That would be also very
confusing for any monitoring job looking at pg_replication_slots.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20180720042520.GD7023@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, sawada.mshk@gmail.com, horiguchi.kyotaro@lab.ntt.co.jp, pgsql-hackers@lists.postgresql.org, thomas.munro@enterprisedb.com, michael.paquier@gmail.com, andres@anarazel.de, peter.eisentraut@2ndquadrant.com
Subject: Re: [HACKERS] Restricting maximum keep segments by repslots
In-Reply-To: <20180720042520.GD7023@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox