From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: logical decoding / rewrite map vs. maxAllocatedDescs
Date: Thu, 9 Aug 2018 13:58:46 -0400
Message-ID: <20180809175846.gyycn5rgbo7eksy5@alvherre.pgsql> (raw)
In-Reply-To: <12170.1533836537@sss.pgh.pa.us>
On 2018-Aug-09, Tom Lane wrote:
> It sounds like whoever wrote that code was completely impervious to the
> API spec for AllocateFile():
>
> * Note that files that will be open for any significant length of time
> * should NOT be handled this way, since they cannot share kernel file
> * descriptors with other files; there is grave risk of running out of FDs
> * if anyone locks down too many FDs.
>
> Perhaps these files should be accessed through fd.c's VFD infrastructure
> rather than ignoring it. Reinventing it is especially not the way to go.
Ah, right. Maybe ReorderBufferRestoreChanges should use
PathNameOpenFile / FileRead ...
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, tomas.vondra@2ndquadrant.com
Subject: Re: logical decoding / rewrite map vs. maxAllocatedDescs
In-Reply-To: <20180809175846.gyycn5rgbo7eksy5@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox