From: Michael Paquier <michael@paquier.xyz>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: hlinnaka <hlinnaka@iki.fi>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Problem while setting the fpw with SIGHUP
Date: Tue, 18 Sep 2018 15:34:57 +0900
Message-ID: <20180918063457.GL31460@paquier.xyz> (raw)
In-Reply-To: <CAA4eK1+Xfx5jD2CHmLPNqXeOzqRLKG9TNr8wfs3-cPf9Ln9RVg@mail.gmail.com>
References: <20180728231911.GB1471@paquier.xyz>
<20180801.162545.234930371.horiguchi.kyotaro@lab.ntt.co.jp>
<CAA4eK1K7dVgKU4zrNTSCW=EoqALG38XmNT0HK9Wdkr935iwTQg@mail.gmail.com>
<20180828.193436.253621888.horiguchi.kyotaro@lab.ntt.co.jp>
<20180906233728.GR2726@paquier.xyz>
<20180914072655.GI29332@paquier.xyz>
<CAA4eK1+Xfx5jD2CHmLPNqXeOzqRLKG9TNr8wfs3-cPf9Ln9RVg@mail.gmail.com>
On Fri, Sep 14, 2018 at 04:30:37PM +0530, Amit Kapila wrote:
> On Fri, Sep 14, 2018 at 12:57 PM Michael Paquier <michael@paquier.xyz> wrote:
>> So, I have been working on this problem again and I have reviewed the
>> thread, and there have been many things discussed in the last couple of
>> months:
>> 1) We do not want to initialize XLogInsert stuff unconditionally for all
>> processes at the moment recovery begins, but we just want to initialize
>> it once WAL write is open for business.
>> 2) Both the checkpointer and the startup process can call
>> UpdateFullPageWrites() which can cause Insert->fullPageWrites to get
>> incorrect values.
>
> Can you share the steps to reproduce this problem?
This refers to the first problem reported on this thread:
https://www.postgresql.org/message-id/CAFiTN-u4BA8KXcQUWDPNgaKAjDXC%3DC2whnzBM8TAcv%3DstckYUw%40mail...
In order to reproduce the problem, you can for example stop the server
in immediate mode. Then attach a debugger to it and add a breakpoint to
UpdateFullPageWrites. You can check that XLOG insert has not been
initialized yet by looking at xloginsert_cxt ot ThisTimeLineID. On a
second session, switch full_page_writes to on or off, reload the
parameters and then trigger a checkpoint. The important point is to
trigger an inconsistency between XLogCtl->Insert->fullPageWrites and
the value of fullPageWrites within the checkpointer context. With the
checkpoint triggered, the debugger will stop at UpdateFullPageWrites
immediately. At this point, you can simply check if fullPageWrites
Insert->fullPageWrites have the same value or a different one. If the
values match, simply switch full_page_writes and reload again, with the
checkpointer still waiting at the beginning of UpdateFullPageWrites.
SIGHUP will make the checkpointer process hang a bit, and then it will
move on. At this point you will be able to see the failure:
TRAP: FailedAssertion("!(CritSectionCount == 0)", File: "mcxt.c", Line: 731)
2018-09-18 15:06:39 JST [7396]: [11-1] db=,user=,app=,client= LOG:
checkpointer process (PID 7399) was terminated by signal 6: Aborted
> On a regular startup when there is no recovery, it won't allow us to
> log the WAL record (XLOG_FPW_CHANGE) which can happen without above
> change. You can check that by setting full_page_writes=off and start
> the system.
Oh, good point, InRecovery is set to false in this case so that would be
skipped. We can simply fix that by adding a flag, say "force" to
UpdateFullPageWrites to allow a process to enforce the update of FPW
even if RecoveryInProgress returns true, which would be the case for the
startup process.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20180918063457.GL31460@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, amit.kapila16@gmail.com, horiguchi.kyotaro@lab.ntt.co.jp, robertmhaas@gmail.com, hlinnaka@iki.fi, dilipbalaut@gmail.com
Subject: Re: Problem while setting the fpw with SIGHUP
In-Reply-To: <20180918063457.GL31460@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox