From: Stephen Frost <sfrost@snowman.net>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: [RFC] Removing "magic" oids
Date: Wed, 17 Oct 2018 11:52:23 -0400
Message-ID: <20181017155223.GC4184@tamriel.snowman.net> (raw)
In-Reply-To: <CA+TgmobCqGhnac0Brwkh-AUqhRMVba73fahLQPe+Z6nEJZoAwQ@mail.gmail.com>
References: <20180930034810.ywp2c7awz7opzcfr@alap3.anarazel.de>
<20181014220923.j4mlgue7y7chv533@alap3.anarazel.de>
<943.1539556490@sss.pgh.pa.us>
<20181014224339.i6pqo7kpgj7x5vq2@alap3.anarazel.de>
<CA+TgmobCqGhnac0Brwkh-AUqhRMVba73fahLQPe+Z6nEJZoAwQ@mail.gmail.com>
Greetings,
* Robert Haas (robertmhaas@gmail.com) wrote:
> On Sun, Oct 14, 2018 at 6:43 PM Andres Freund <andres@anarazel.de> wrote:
> > I'm not sure we want that however - yes, the short time pain will be
> > lower, but do we really want to inflict the confusion about invisible
> > oids on our users for the next 20 years? I think there's a fair argument
> > to be made that we should cause pain once, rather continuing to inflict
> > lower doeses of pain.
>
> Yeah, I think that argument has quite a bit of merit. I suspect that
> there are a lot of people who expect that 'SELECT * FROM pg_whatever'
> is going to show them all of the data in pg_whatever, and take a while
> to figure out that it really doesn't. I know better and still mess
> this up with some regularity. Anyone who finds it unintuitive that *
> doesn't really mean everything is going to be happier with this change
> in the long run.
>
> In the short run, it is indeed possible that some catalog queries will
> break. But, really, how many? For the most part, automated queries
> written by tools probably select specific columns rather than
> everything, and IIUC those won't break. And even if they do use
> 'SELECT *', won't they just end up with two copies of the OID column?
> That might work fine.
>
> Of course it might not, and then you'd have to fix your code, but it's
> not obvious to me that this would be a horror show.
I tend to agree that this won't be as much of a horror show as made out
to be up-thread. Tools should certainly be using explicit column names
and if they aren't then we're breaking them regularly anyway whenever
we change what columns exist in a given catalog table.
All the column renaming we did for v10 strikes me as a much bigger deal
than this change and while we did hear some complaints about that, I
certainly feel like it was worth it and that people generally
understood.
Thanks!
Stephen
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, robertmhaas@gmail.com, andres@anarazel.de, tgl@sss.pgh.pa.us
Subject: Re: [RFC] Removing "magic" oids
In-Reply-To: <20181017155223.GC4184@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox