From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: David Rowley <david.rowley@2ndquadrant.com>
Cc: Edmund Horner <ejrh00@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Tid scan improvements
Date: Tue, 6 Nov 2018 00:52:49 -0300
Message-ID: <20181106035249.rtukjc24gm56sjc7@alvherre.pgsql> (raw)
In-Reply-To: <CAKJS1f9+etR1VGkqp=hkGWn3EofWJVFnjKaTpHZva2PKhALdng@mail.gmail.com>
On 2018-Nov-06, David Rowley wrote:
> 14. we pass 'false' to what?
>
> + * save the tuple and the buffer returned to us by the access methods in
> + * our scan tuple slot and return the slot. Note: we pass 'false' because
> + * tuples returned by heap_getnext() are pointers onto disk pages and were
> + * not created with palloc() and so should not be pfree()'d. Note also
> + * that ExecStoreHeapTuple will increment the refcount of the buffer; the
> + * refcount will not be dropped until the tuple table slot is cleared.
> */
Seems a mistake stemming from 29c94e03c7d0 ...
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, david.rowley@2ndquadrant.com, ejrh00@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Tid scan improvements
In-Reply-To: <20181106035249.rtukjc24gm56sjc7@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox