From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Amit Langote <amitlangote09@gmail.com>
Subject: Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation
Date: Thu, 8 Nov 2018 12:51:54 -0300
Message-ID: <20181108155154.jq623btpai6ufbw3@alvherre.pgsql> (raw)
In-Reply-To: <f9ac27e1-067d-ea4b-14d9-824769a93ee7@lab.ntt.co.jp>
On 2018-Nov-07, Amit Langote wrote:
> I think the result in this case should be an error, just as it would in
> the regular inheritance case.
>
> create table parent (a text);
> create table child (a text collate "en_US") inherits (parent);
> NOTICE: merging column "a" with inherited definition
> ERROR: column "a" has a collation conflict
> DETAIL: "default" versus "en_US"
>
> In fact, I see that ATTACH PARTITION rejects a partition if collations
> don't match.
Hmm, I'm thinking perhaps we shouldn't backpatch this part. It's
obviously a bug, but we might break somebody's working apps. Therefore
I think I'd rather leave it out of the current bugfix and commit
separately.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, Langote_Amit_f8@lab.ntt.co.jp, ashutosh.bapat@enterprisedb.com, pgsql-hackers@lists.postgresql.org, amitlangote09@gmail.com
Subject: Re: BUG #15212: Default values in partition tables don't work as expected and allow NOT NULL violation
In-Reply-To: <20181108155154.jq623btpai6ufbw3@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox