From: Stephen Frost <sfrost@snowman.net>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Subject: Re: pg_partition_tree crashes for a non-defined relation
Date: Sun, 9 Dec 2018 12:49:18 -0500
Message-ID: <20181209174917.GE3415@tamriel.snowman.net> (raw)
In-Reply-To: <20181208235926.GB1833@paquier.xyz>
References: <20181207010406.GO2407@paquier.xyz>
<20181207230540.GA12740@paquier.xyz>
<6105.1544243612@sss.pgh.pa.us>
<20181208065436.GC1989@paquier.xyz>
<20181208134608.GY3415@tamriel.snowman.net>
<20181208231507.GA1833@paquier.xyz>
<20181208235926.GB1833@paquier.xyz>
Greetings,
* Michael Paquier (michael@paquier.xyz) wrote:
> On Sun, Dec 09, 2018 at 08:15:07AM +0900, Michael Paquier wrote:
> > On Sat, Dec 08, 2018 at 08:46:08AM -0500, Stephen Frost wrote:
> >> We should really have a more clearly defined policy around this, but my
> >> recollection is that we often prefer to return NULL rather than throwing
> >> an error for the convenience of people doing things like querying
> >> pg_class using similar functions.
> >
> > Yes, that's visibly right. At least that's what I can see from the
> > various pg_get_*def and pg_*_is_visible. Returning NULL would indeed
> > be more consistent.
>
> Thinking more about your argument, scanning fully pg_class is quite
> sensible as well because there is no need to apply an extra qual on
> relkind, so let's change the function as you suggest, by returning NULL
> on invalid relation type. Any opinions about the attached then which
> does the switch?
Looks alright on a quick glance, but shouldn't you also update the
comment..?
Thanks!
Stephen
Attachments:
[application/pgp-signature] signature.asc (818B, ../20181209174917.GE3415@tamriel.snowman.net/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: sfrost@snowman.net, michael@paquier.xyz, tgl@sss.pgh.pa.us, Langote_Amit_f8@lab.ntt.co.jp
Subject: Re: pg_partition_tree crashes for a non-defined relation
In-Reply-To: <20181209174917.GE3415@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox