pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Stephen Frost <sfrost@snowman.net>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Andreas Karlsson <andreas@proxel.se>
Cc: PostgreSQL mailing lists <pgsql-hackers@postgresql.org>
Cc: Craig Ringer <craig@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Subject: Re: [HACKERS] REINDEX CONCURRENTLY 2.0
Date: Thu, 13 Dec 2018 19:14:57 -0500
Message-ID: <20181214001457.GP3415@tamriel.snowman.net> (raw)
In-Reply-To: <52aae11b-bfa5-6ccc-3b98-774f4836ab42@2ndquadrant.com>
References: <CAB7nPqSS7xVKGkQbroiJ_wFgxa9n3COnemGzeXv36-A3XLbAeg@mail.gmail.com>
	<CAMsr+YGhS541Zx7kmda5SXLS3NLeY71HksZrbRsRbbS3VaXfkQ@mail.gmail.com>
	<20180126022813.GD2416@tamriel.snowman.net>
	<9523ad05-525c-598e-ad2d-061b5a94062c@proxel.se>
	<20180201062158.GD6398@paquier.xyz>
	<60052986-956b-4478-45ed-8bd119e9b9cf@2ndquadrant.com>
	<10797471544200851@myt3-964eae3a5b05.qloud-c.yandex.net>
	<93a3d2fb-43a0-cf14-e8d0-d2c3195c1e5b@2ndquadrant.com>
	<20486991544381729@iva5-d3020dc3459d.qloud-c.yandex.net>
	<52aae11b-bfa5-6ccc-3b98-774f4836ab42@2ndquadrant.com>

Greetings,

* Peter Eisentraut (peter.eisentraut@2ndquadrant.com) wrote:
> On 09/12/2018 19:55, Sergei Kornilov wrote:
> >> reindex table CONCURRENTLY test;
> 
> By the way, does this syntax make sense?  I haven't seen a discussion on
> this anywhere in the various threads.  I keep thinking that
> 
>     reindex concurrently table test;
> 
> would make more sense.  How about in combination with (verbose)?

I don't think it's a mistake that we have 'create index concurrently'
and it certainly would seem odd to me for 'create index' and 'reindex
table' to be different.

Certainly, from my recollection of english, you'd say "I am going to
reindex the table concurrently", you wouldn't say "I am going to
reindex concurrently the table."

Based on at least a quick looking around, the actual grammar rule seems
to match my recollection[1], adverbs should typically go AFTER the
verb + object, and the adverb shouldn't ever be placed between the verb
and the object.

Thanks!

Stephen

[1]: http://www.grammar.cl/Notes/Adverbs.htm

Attachments:

  [application/pgp-signature] signature.asc (818B, ../20181214001457.GP3415@tamriel.snowman.net/2-signature.asc)
  download

view thread (170+ messages)  latest in thread

Message-ID: <20181214001457.GP3415@tamriel.snowman.net>
Permalink:  ../20181214001457.GP3415@tamriel.snowman.net/
Also on:    postgresql.org/message-id/20181214001457.GP3415@tamriel.snowman.net

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: sfrost@snowman.net, peter.eisentraut@2ndquadrant.com, sk@zsrv.org, michael.paquier@gmail.com, andreas@proxel.se, craig@2ndquadrant.com, alvherre@alvh.no-ip.org
  Subject: Re: [HACKERS] REINDEX CONCURRENTLY 2.0
  In-Reply-To: <20181214001457.GP3415@tamriel.snowman.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox