From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: PostgreSQL Developers <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] pgbench - allow to store select results into variables
Date: Thu, 10 Jan 2019 16:49:35 -0300
Message-ID: <201901101949.wdjmpfsh6hzw@alvherre.pgsql> (raw)
In-Reply-To: <4245.1547147665@sss.pgh.pa.us>
On 2019-Jan-10, Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > On 2019-Jan-10, Tom Lane wrote:
> >> This \cset thing seem like an incredibly badly thought out kluge.
> >> What is its excuse to live?
>
> > The reason is that you can set variables from several queries in one
> > network trip.
>
> So who needs that? Just merge the queries, if it's so important that
> you avoid multiple round trips.
Hmm, I suppose that's true.
> > We can take it out I guess, but my impression was that we already pretty
> > much had a consensus that it was wanted.
>
> Maybe if the implementation weren't a pile of junk it'd be all right,
> but as-is this is a mess. The dependency on counting \; in particular
> is setting me off, because that has little if anything to do with the
> number of query results to be expected. I imagine the argument will
> be that nobody would write the sort of queries that break that assumption
> in a pgbench script; but I don't find that kind of design to be up
> to project standards, especially not when the argument for the feature
> is tissue-thin in the first place.
There's a lot of the new code in pgbench that can be simplified if we
remove \cset.
I'll leave time for others to argue for or against cset, and then act
accordingly.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, coelho@cri.ensmp.fr, michael@paquier.xyz, sfrost@snowman.net, andrew.dunstan@2ndquadrant.com
Subject: Re: [HACKERS] pgbench - allow to store select results into variables
In-Reply-To: <201901101949.wdjmpfsh6hzw@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox