From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Imai, Yoshikazu <imai.yoshikazu@jp.fujitsu.com>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: speeding up planning with partitions
Date: Wed, 30 Jan 2019 00:25:53 -0300
Message-ID: <201901300325.ptdcgkb5kta5@alvherre.pgsql> (raw)
In-Reply-To: <0F97FA9ABBDBE54F91744A9B37151A5125CE37@g01jpexmbkw24>
On 2019-Jan-30, Imai, Yoshikazu wrote:
> Why I did these tests is that I wanted to confirm that even if we
> apply each patch one by one, there's no performance problem. Because
> patches are quite large, I just felt it might be difficult to commit
> these patches all at once and I thought committing patch one by one
> would be another option to commit these patches. I don't know there is
> the rule in the community how patches should be committed, and if
> there, my thoughts above may be bad.
There are no absolute rules, but if I was committing it, I would
certainly commit each separately, mostly because reviewing the whole
series at once looks daunting ... and given the proposed commit
messages, I'd guess that writing a combined commit message would also be
very difficult.
So thanks for doing these tests.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, imai.yoshikazu@jp.fujitsu.com, Langote_Amit_f8@lab.ntt.co.jp, david.rowley@2ndquadrant.com, amitlangote09@gmail.com
Subject: Re: speeding up planning with partitions
In-Reply-To: <201901300325.ptdcgkb5kta5@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox