From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Chapman Flack <chap@anastigmatix.net>
Cc: Amit Khandekar <amitdkhan.pg@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: ArchiveEntry optional arguments refactoring
Date: Fri, 1 Feb 2019 11:30:58 -0300
Message-ID: <201902011430.2cm3lirklmed@alvherre.pgsql> (raw)
In-Reply-To: <CA+q6zcUhr+jODQ_NjqQZhDc=Zkq445_QW148pgAKuWEach=JWQ@mail.gmail.com>
On 2019-Feb-01, Dmitry Dolgov wrote:
> > On Fri, Feb 1, 2019 at 12:33 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> > > * Use NULL as a default value where it was an empty string before (this
> > > required few minor changes for some part of the code outside ArchiveEntry)
> >
> > I would rename the function to sanitize_line() and put those comments there
> > (removing them from the callsites), then the new argument I suggest would not
> > be completely out of place.
>
> Yes, sounds pretty reasonable for me.
Thanks for looking -- pushed.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, 9erthalion6@gmail.com, andres@anarazel.de, tgl@sss.pgh.pa.us, chap@anastigmatix.net, amitdkhan.pg@gmail.com
Subject: Re: ArchiveEntry optional arguments refactoring
In-Reply-To: <201902011430.2cm3lirklmed@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox