From: Noah Misch <noah@leadboat.com>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Synchronize with imath upstream
Date: Sun, 3 Feb 2019 00:11:24 -0800
Message-ID: <20190203081124.GC6226@rfd.leadboat.com> (raw)
In-Reply-To: <87lg2x73cg.fsf@news-spur.riddles.org.uk>
References: <20190203035704.GA6226@rfd.leadboat.com>
<87lg2x73cg.fsf@news-spur.riddles.org.uk>
On Sun, Feb 03, 2019 at 07:07:36AM +0000, Andrew Gierth wrote:
> In that case I propose that we avoid the whole issue by removing
> -Wdeclaration-after-statement entirely.
Some folks who skip $SUBJECT will be interested in your proposal. If you wish
to pursue that proposal, please start a new thread.
On Sun, Feb 03, 2019 at 07:14:13AM +0000, Andrew Gierth wrote:
> >>>>> "Noah" == Noah Misch <noah@leadboat.com> writes:
>
> Noah> - # -Wdeclaration-after-statement isn't applicable for C++
> Noah> + # -Wdeclaration-after-statement isn't applicable for C++. Specific C files
> Noah> + # disable it, so AC_SUBST the negative form.
> Noah> + PERMIT_DECLARATION_AFTER_STATEMENT=
> Noah> + if test x"$save_CFLAGS" != "$CFLAGS"; then
>
> Missing "x" here?
>
> + if test x"$save_CFLAGS" != x"$CFLAGS"; then
I'll incorporate your fix. Thanks.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, andrew@tao11.riddles.org.uk
Subject: Re: Synchronize with imath upstream
In-Reply-To: <20190203081124.GC6226@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox