From: David Fetter <david@fetter.org>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Noah Misch <noah@leadboat.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Synchronize with imath upstream
Date: Sun, 3 Feb 2019 18:36:50 +0100
Message-ID: <20190203173650.GA18487@fetter.org> (raw)
In-Reply-To: <87tvhl75aw.fsf@news-spur.riddles.org.uk>
References: <20190203035704.GA6226@rfd.leadboat.com>
<87y36x76r7.fsf@news-spur.riddles.org.uk>
<20190203062048.GB6226@rfd.leadboat.com>
<87tvhl75aw.fsf@news-spur.riddles.org.uk>
On Sun, Feb 03, 2019 at 07:07:36AM +0000, Andrew Gierth wrote:
> >>>>> "Noah" == Noah Misch <noah@leadboat.com> writes:
>
> >> I found it much simpler to strip out -Wdeclaration-after-statement
> >> instead:
> >>
> >> $(RYU_OBJS): override CFLAGS := $(filter-out -Wdeclaration-after-statement,$(CFLAGS))
>
> Noah> The -Wno-declaration-after-statement approach takes eight lines
> Noah> of code, and the filter-out approach takes one. On the other
> Noah> hand, using $(filter-out) changes any runs of whitespace to
> Noah> single spaces ("$(filter-out foo,a b c)" yields "a b c"). We do
> Noah> risk that with CPPFLAGS and LDFLAGS in a few places. I don't want
> Noah> to proliferate that practice, because it changes semantics of
> Noah> CFLAGS containing -DFOO="arbitrary text".
>
> In that case I propose that we avoid the whole issue by removing
> -Wdeclaration-after-statement entirely.
>
> So far, expressed opinions have run about 4:2 in favour of allowing
> mixed declarations and code.
+1 for this.
Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: david@fetter.org, andrew@tao11.riddles.org.uk, noah@leadboat.com
Subject: Re: Synchronize with imath upstream
In-Reply-To: <20190203173650.GA18487@fetter.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox