From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: fast defaults in heap_getattr vs heap_deform_tuple
Date: Tue, 5 Feb 2019 22:44:38 -0300
Message-ID: <20190206014438.GA3755@alvherre.pgsql> (raw)
In-Reply-To: <20190205165705.7cqrwvjxvip7dcow@alap3.anarazel.de>
On 2019-Feb-05, Andres Freund wrote:
> @@ -82,7 +80,7 @@ static Datum getmissingattr(TupleDesc tupleDesc, int attnum, bool *isnull);
> /*
> * Return the missing value of an attribute, or NULL if there isn't one.
> */
> -static Datum
> +Datum
> getmissingattr(TupleDesc tupleDesc,
> int attnum, bool *isnull)
This is a terrible name for an exported function -- let's change it
before it gets exported. Heck, even heap_getmissingattr() would be
better.
I notice that with this patch, heap_getattr() obtains a new Assert()
that the attr being fetched is no further than tupledesc->natts.
It previously just returned null for that case. Maybe we should change
it so that it returns null if an attr beyond end-of-array is fetched?
(I think in non-assert builds, it would dereference past the AttrMissing
array.)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, andres@anarazel.de, andrew.dunstan@2ndquadrant.com
Subject: Re: fast defaults in heap_getattr vs heap_deform_tuple
In-Reply-To: <20190206014438.GA3755@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox